From: Choong Yong Liang <yong.liang.choong@linux.intel.com>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: "Hans de Goede" <hdegoede@redhat.com>,
"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>,
"David E Box" <david.e.box@linux.intel.com>,
platform-driver-x86@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1] platform/x86: intel_pmc_ipc: add option to build without ACPI
Date: Thu, 13 Mar 2025 16:59:21 +0800 [thread overview]
Message-ID: <21d10c76-6f8b-4050-aa7d-59b12b3c5e85@linux.intel.com> (raw)
In-Reply-To: <CAHp75VeLhHh_xhxUb5fsk71ck_m9SGUeXjH8taq+JYjEpHdk2Q@mail.gmail.com>
On 12/3/2025 10:00 pm, Andy Shevchenko wrote:
> On Wed, Mar 12, 2025 at 1:23 PM Choong Yong Liang
> <yong.liang.choong@linux.intel.com> wrote:
>> On 12/3/2025 3:54 pm, Andy Shevchenko wrote:
>>> On Wed, Mar 12, 2025 at 4:30 AM Choong Yong Liang
>>> <yong.liang.choong@linux.intel.com> wrote:
>
> ...
>
>> Thank you for your detailed feedback and suggestions. I'll make the
>> necessary adjustments to the patch based on your comments above.
>>
>>>> Signed-off-by: David E. Box <david.e.box@linux.intel.com>
>>>> Signed-off-by: Choong Yong Liang <yong.liang.choong@linux.intel.com>
>>>
>>> This is wrong as either it's a wrong tag (SoB --> Suggested-by?), or
>>> missing Co-developed-by, or wrong order (but in that case David should
>>> have sent the patch).
>>>
>> I believe the sequence is still correct, as the solution was provided by
>> David, and he should be the main author. I'm just the submitter, so my
>> sign-off should be placed last.
>
> You are the submitter *and* the author in this case. As I said, that
> SoB chain is wrong in its current form.
>
Hi Andy,
I believe this time I have correctly attributed the authorship by following
the guide from:
https://docs.kernel.org/process/submitting-patches.html#when-to-use-acked-by-cc-and-co-developed-by
---
From: David E. Box <david.e.box@linux.intel.com>
<changelog>
Signed-off-by: David E. Box <david.e.box@linux.intel.com>
Co-developed-by: Choong Yong Liang <yong.liang.choong@linux.intel.com>
Signed-off-by: Choong Yong Liang <yong.liang.choong@linux.intel.com>
---
prev parent reply other threads:[~2025-03-13 8:59 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-12 2:29 [PATCH v1] platform/x86: intel_pmc_ipc: add option to build without ACPI Choong Yong Liang
2025-03-12 7:54 ` Andy Shevchenko
2025-03-12 11:23 ` Choong Yong Liang
2025-03-12 14:00 ` Andy Shevchenko
2025-03-13 8:59 ` Choong Yong Liang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=21d10c76-6f8b-4050-aa7d-59b12b3c5e85@linux.intel.com \
--to=yong.liang.choong@linux.intel.com \
--cc=andy.shevchenko@gmail.com \
--cc=david.e.box@linux.intel.com \
--cc=hdegoede@redhat.com \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox