* [PATCH] mark inter_module_* deprecated
@ 2004-09-19 10:13 Christoph Hellwig
2004-09-23 1:53 ` Dave Airlie
0 siblings, 1 reply; 3+ messages in thread
From: Christoph Hellwig @ 2004-09-19 10:13 UTC (permalink / raw)
To: akpm; +Cc: linux-kernel
These had been officially deprecated since Rusty's module rewrite, but
never got the __deprecated marker. The only remaining users are drm and
mtd, so we'll get some warnings for common builds. But maybe that's the
only way to get the drm people to fix the mess :)
--- 1.79/include/linux/module.h 2004-06-27 09:19:28 +02:00
+++ edited/include/linux/module.h 2004-09-19 11:52:33 +02:00
@@ -580,10 +580,12 @@
/* Use symbol_get and symbol_put instead. You'll thank me. */
#define HAVE_INTER_MODULE
-extern void inter_module_register(const char *, struct module *, const void *);
-extern void inter_module_unregister(const char *);
-extern const void *inter_module_get(const char *);
-extern const void *inter_module_get_request(const char *, const char *);
-extern void inter_module_put(const char *);
+extern void __deprecated inter_module_register(const char *,
+ struct module *, const void *);
+extern void __deprecated inter_module_unregister(const char *);
+extern const void * __deprecated inter_module_get(const char *);
+extern const void * __deprecated inter_module_get_request(const char *,
+ const char *);
+extern void __deprecated inter_module_put(const char *);
#endif /* _LINUX_MODULE_H */
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] mark inter_module_* deprecated
2004-09-19 10:13 [PATCH] mark inter_module_* deprecated Christoph Hellwig
@ 2004-09-23 1:53 ` Dave Airlie
2004-09-23 16:13 ` Alan Cox
0 siblings, 1 reply; 3+ messages in thread
From: Dave Airlie @ 2004-09-23 1:53 UTC (permalink / raw)
To: Christoph Hellwig; +Cc: akpm, linux-kernel
On Sun, 19 Sep 2004 12:13:38 +0200, Christoph Hellwig <hch@lst.de> wrote:
> These had been officially deprecated since Rusty's module rewrite, but
> never got the __deprecated marker. The only remaining users are drm and
> mtd, so we'll get some warnings for common builds. But maybe that's the
> only way to get the drm people to fix the mess :)
>
It'll piss a few people off but it won't create time, the only thing
stopping the drm from getting this stuff out of the way is time, there
are two uses in the DRM, one is the agp one, this is easy, Rusty
posted a patch for this and I'll probably merge it up after the next
kernel release.. the other use requries moving to some sort of DRM
in-kernel core, again I'd rather do this at the start of a kernel
release cycle as it'll require a bit of testing to make sure we don't
break anything....
Most of this stuff is easier if we weren't waiting on Alans vga class
support driver to turn up as without it the DRM CVS is blocked, and no
DRM developer really wants to start hacking on the vga class stuff as
we don't believe it is where our time is best spent until Alan gets
code merged into the kernel and gets the fb guys to convert all their
drivers... I've already got a patch for converting the DRM to a fixed
up version of his last patch...
Dave.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] mark inter_module_* deprecated
2004-09-23 1:53 ` Dave Airlie
@ 2004-09-23 16:13 ` Alan Cox
0 siblings, 0 replies; 3+ messages in thread
From: Alan Cox @ 2004-09-23 16:13 UTC (permalink / raw)
To: Dave Airlie; +Cc: Christoph Hellwig, akpm, Linux Kernel Mailing List
On Iau, 2004-09-23 at 02:53, Dave Airlie wrote:
> Most of this stuff is easier if we weren't waiting on Alans vga class
> support driver to turn up as without it the DRM CVS is blocked, and no
> DRM developer really wants to start hacking on the vga class stuff as
> we don't believe it is where our time is best spent until Alan gets
> code merged into the kernel and gets the fb guys to convert all their
> drivers... I've already got a patch for converting the DRM to a fixed
> up version of his last patch...
If you've got it working and everyone is happy just submit it. It looks
like I'm going to be tty driver hacking for some time yet and you've
already done the hardest bit - debugging it.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2004-09-23 17:21 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2004-09-19 10:13 [PATCH] mark inter_module_* deprecated Christoph Hellwig
2004-09-23 1:53 ` Dave Airlie
2004-09-23 16:13 ` Alan Cox
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox