From: Dave Airlie <airlied@gmail.com>
To: Ingo Molnar <mingo@elte.hu>
Cc: Dave Airlie <airlied@linux.ie>, Andrew Morton <akpm@osdl.org>,
torvalds@osdl.org, linux-kernel@vger.kernel.org
Subject: Re: SiS drm broken during 2.6.9-rc1-bk1
Date: Mon, 27 Jun 2005 09:07:28 +1000 [thread overview]
Message-ID: <21d7e997050626160729afdff2@mail.gmail.com> (raw)
In-Reply-To: <20050215103207.GA19866@elte.hu>
> > > layout is the most likely patch to have broken things... I haven't
> > > confirmed it is this particular patch yet, tomorrow I'll get some time to
> > > do it ..
> > >
> >
> > okay running client applications using
> >
> > setarch -L i386 glxgears
> >
> > makes them work.. I'll start looking for a bug in the the SIS client
> > side library..
>
> yeah. Look for 2GB assumptions - e.g. assumptions that pointers cast to
> integer will be positive values, such as:
>
> int i;
>
> i = malloc(somesize);
> if (i <= 0)
> handle_alloc_failure();
>
> here with the topdown layout you'd get a malloc 'failure'.
Just for completeness, Thomas Winischoffer tracked this down over the
weekend, I had stared at it previously to no great avail,
The issue was with the user space SiS Mesa driver having an
uninitialised structure on the stack for the copy command sent to the
DRM, with the old layout it would end up with zero'ed reserved fields
by luck most of the time, with the new one it went the other way..
the fix is now in Mesa CVS....
Dave.
next prev parent reply other threads:[~2005-06-26 23:08 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-02-13 11:29 SiS drm broken during 2.6.9-rc1-bk1 Dave Airlie
2005-02-14 8:26 ` Dave Airlie
2005-02-15 10:32 ` Ingo Molnar
2005-06-26 23:07 ` Dave Airlie [this message]
2005-06-27 7:31 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=21d7e997050626160729afdff2@mail.gmail.com \
--to=airlied@gmail.com \
--cc=airlied@linux.ie \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox