From: Dave Airlie <airlied@gmail.com>
To: Linus Torvalds <torvalds@osdl.org>
Cc: Pavel Machek <pavel@ucw.cz>,
ambx1@neo.rr.com, Hugh Dickins <hugh@veritas.com>,
Andrew Morton <akpm@osdl.org>,
Dominik Brodowski <linux@dominikbrodowski.net>,
Daniel Ritz <daniel.ritz@gmx.ch>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Len Brown <len.brown@intel.com>
Subject: Re: revert yenta free_irq on suspend
Date: Mon, 1 Aug 2005 09:59:37 +1000 [thread overview]
Message-ID: <21d7e9970507311659259e5560@mail.gmail.com> (raw)
In-Reply-To: <Pine.LNX.4.58.0507311635360.14342@g5.osdl.org>
>
> If an interrupt is screaming due to lack of initialization and gets turned
> off, just make sure it gets re-enabled when it is being initialized.
>
That still doesn't handle the case where a device has an interrupt
handler on a shared IRQ and another device on the chain interrupts it
after it has suspended its device,
we need to either fix *for all drivers* (otherwise people sharing IRQs
will have breakages that people not sharing them won't see ... )
a) add request/free irq sets
b) add code to the interrupt handlers to make sure we aren't in a
powerdown state...
I don't really mind which is the recommended one I'd just prefer we do
it the same way everwhere... so I still believe the yenta_irq patch is
correct if we are doing a, or if not we need to do b....
Dave.
next prev parent reply other threads:[~2005-07-31 23:59 UTC|newest]
Thread overview: 58+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-07-31 20:34 revert yenta free_irq on suspend ambx1
2005-07-31 21:20 ` Pavel Machek
2005-08-01 8:56 ` Benjamin Herrenschmidt
2005-07-31 22:55 ` Linus Torvalds
2005-07-31 23:05 ` Pavel Machek
2005-07-31 23:24 ` Linus Torvalds
2005-07-31 23:27 ` Pavel Machek
2005-07-31 23:44 ` Linus Torvalds
2005-07-31 23:59 ` Dave Airlie [this message]
2005-08-01 0:19 ` Linus Torvalds
2005-08-01 0:44 ` Dave Airlie
2005-08-01 1:07 ` Linus Torvalds
2005-08-01 7:15 ` Pavel Machek
2005-08-01 7:01 ` Sanjoy Mahajan
2005-08-01 7:25 ` Pavel Machek
2005-07-31 23:10 ` Dave Airlie
2005-08-01 1:59 ` Shaohua Li
2005-08-01 2:06 ` Andrew Morton
2005-08-01 2:22 ` Shaohua Li
2005-08-01 7:19 ` Pavel Machek
2005-08-01 21:38 ` Rafael J. Wysocki
-- strict thread matches above, loose matches on Subject: below --
2005-08-01 3:03 ambx1
2005-08-01 4:53 ` Linus Torvalds
2005-08-01 8:49 ` Benjamin Herrenschmidt
2005-08-02 10:56 ` Pavel Machek
2005-08-03 11:42 ` Benjamin Herrenschmidt
2005-07-31 5:03 Brown, Len
2005-07-31 5:31 ` Linus Torvalds
2005-07-31 9:49 ` Rafael J. Wysocki
2005-07-31 22:27 ` Dave Jones
2005-08-01 0:00 ` Andreas Steinmetz
2005-08-01 0:06 ` Dave Jones
2005-08-01 0:09 ` Andreas Steinmetz
2005-08-03 9:23 ` Pavel Machek
2005-08-01 8:51 ` Matthew Garrett
2005-07-30 19:10 Hugh Dickins
2005-07-30 20:03 ` Russell King
2005-07-30 20:36 ` Linus Torvalds
2005-07-30 20:54 ` Russell King
2005-07-30 21:10 ` Linus Torvalds
2005-07-30 21:30 ` Russell King
2005-07-30 22:28 ` Rafael J. Wysocki
2005-07-31 4:49 ` Linus Torvalds
2005-08-01 9:06 ` Benjamin Herrenschmidt
2005-07-30 21:20 ` Rafael J. Wysocki
2005-07-30 20:34 ` Linus Torvalds
2005-07-31 13:29 ` Pavel Machek
2005-07-31 15:53 ` Linus Torvalds
2005-07-31 17:09 ` Linus Torvalds
2005-07-30 20:49 ` Rafael J. Wysocki
2005-07-30 21:08 ` Daniel Ritz
2005-07-30 21:32 ` Hugh Dickins
2005-07-30 22:00 ` Rafael J. Wysocki
2005-07-30 22:24 ` Hugh Dickins
2005-07-30 23:09 ` Rafael J. Wysocki
2005-07-31 20:15 ` Rafael J. Wysocki
2005-08-01 20:34 ` Hugh Dickins
2005-08-01 21:54 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=21d7e9970507311659259e5560@mail.gmail.com \
--to=airlied@gmail.com \
--cc=akpm@osdl.org \
--cc=ambx1@neo.rr.com \
--cc=daniel.ritz@gmx.ch \
--cc=hugh@veritas.com \
--cc=len.brown@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@dominikbrodowski.net \
--cc=pavel@ucw.cz \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox