Re: revert yenta free_irq on suspend

Rafael J. Wysocki
2005-07-31T09:44:35Z

On Sunday, 31 of July 2005 07:03, Brown, Len wrote:
> >So I guess I'll just have to revert the ACPI change that
> >caused drivers to do request_irq/free_irq. I'd prefer it
> >if the ACPI people did that revert themselves, though.
>
> If that is what you want, I'll be happy to do it.
>
> If one believes that suspend/resume is working on a large number of
> systems -- working to a level that a distro can acutally support it,
> then restoring our temporary resume IRQ router hack to make many systems
> work
> is clearly the right thing to do.
>
> But that believe would be total fantasy -- supsend/resume is not
> working on a large number of machines, and no distro is currently
> able to support it. (I'm talking about S3 suspend to RAM primarily,
> suspend to disk is less interesting -- though Red Hat doesn't
> even support _that_)
>
> We can got back to the old hack, but it will probably just delay
> the day that suspend/resume is working broadly, and actually
> can be deployed and supported by distros.

May I propose to keep this change in -mm?

This issue has already been discussed on the linux-pm list and the people
there seem to agree thet the way to go is to convert all PCI drivers to the
model in which they drop their IRQs on suspend and request them back on
resume (ref. http://lists.osdl.org/pipermail/linux-pm/2005-May/000955.html).

There are some drivers that already do it (eg the USB drivers), but there are
many drivers that don't and in fact the recent problems have been related to
them. If the change stays in -mm we will be able to convert the drivers
gradually and they will hopefully get some testing. When it's done, it
will be safe to push the change along with the converted drivers to
mainline.

Greets,
Rafael

--
- Would you tell me, please, which way I ought to go from here?
- That depends a good deal on where you want to get to.
-- Lewis Carroll "Alice's Adventures in Wonderland"