Re: revert yenta free_irq on suspend

Andreas Steinmetz
2005-08-01T00:00:57Z

Dave Jones wrote:
> On Sun, Jul 31, 2005 at 01:03:56AM -0400, Brown, Len wrote:
>
> > But that believe would be total fantasy -- supsend/resume is not
> > working on a large number of machines, and no distro is currently
> > able to support it. (I'm talking about S3 suspend to RAM primarily,
> > suspend to disk is less interesting -- though Red Hat doesn't
> > even support _that_)
>
> After the 'swsusp works just fine' lovefest at OLS, I spent a little
> while playing with the current in-tree swsusp implementation last week.
>
> The outcome: I'm no more enthusiastic about enabling this in Red Hat
> kernels than I ever was before. It seems to have real issues with LVM
> setups (which is default on Red Hat/Fedora installs these days).
> After convincing it where to suspend/resume from by feeding it
> the major/minor of my swap partition, it did actually seem
> to suspend. And resume (though it did spew lots of 'sleeping whilst
> atomic warnings, but thats trivial compared to whats coming up next).
>
> I rebooted, and fsck found all sorts of damage on my / partition.
> After spending 30 minutes pressing 'y', to fix things up, it failed
> to boot after lots of files were missing.
> Why it wrote anything to completely different lv to where I told it
> (and yes, I did get the major:minor right) I have no idea, but
> as it stands, it definitly isn't production-ready.
>
> I'll look into it again sometime soon, but not until after I've
> reinstalled my laptop. (I'm just thankful I had the sense not to
> try this whilst I was at OLS).

Hmm,
I'm using swsusp on my x86_64 laptop with lvm and dm-crypt. Works just
fine except for nasty spontaneous reboots from time to time caused by
yenta_socket (I do get these since I started to access my pcmcia flash
disk from initrd to retrieve the dm-crypt swap key). It does work since
at least 2.6.11 up to 2.6.13-rc4 and if the yenta_socket caused
spontaneous reboots after resume could be fixed I'd call it production
ready.

gringo:~ # fdisk -l /dev/hda

Disk /dev/hda: 80.0 GB, 80026361856 bytes
255 heads, 63 sectors/track, 9729 cylinders
Units = cylinders of 16065 * 512 = 8225280 bytes

Device Boot Start End Blocks Id System
/dev/hda1 1 244 1959898+ 83 Linux
/dev/hda2 245 488 1959930 82 Linux swap / Solaris
/dev/hda3 489 732 1959930 82 Linux swap / Solaris
/dev/hda4 733 9729 72268402+ 5 Extended
/dev/hda5 733 976 1959898+ 82 Linux swap / Solaris
/dev/hda6 977 9729 70308441 88 Linux plaintext (*)

(*) dm-crypt :-)

gringo:~ # vgdisplay
--- Volume group ---
VG Name rootvg
System ID
Format lvm2
Metadata Areas 1
Metadata Sequence No 27
VG Access read/write
VG Status resizable
MAX LV 0
Cur LV 8
Open LV 8
Max PV 0
Cur PV 1
Act PV 1
VG Size 67.05 GB
PE Size 4.00 MB
Total PE 17165
Alloc PE / Size 14464 / 56.50 GB
Free PE / Size 2701 / 10.55 GB
VG UUID oHluq0-H5Nd-90dU-psLn-ygNT-u4GJ-D8aJhG

All filesystems are ext3 as I did have nasty experiences with reiserfs
on lvm+raid on another 2.6 system without ever using swsusp there.
--
Andreas Steinmetz SPAMmers use robotrap@domdv.de