Re: revert yenta free_irq on suspend

Russell King
2005-07-30T20:55:08Z

On Sat, Jul 30, 2005 at 01:36:24PM -0700, Linus Torvalds wrote:
> On Sat, 30 Jul 2005, Russell King wrote:
> >
> > What this probably means is that we need some way to turn off interrupts
> > from devices on suspend, and on resume, keep them off until drivers
> > have had a chance to quiesce all devices, turn them back on, and then
> > do full resume.
>
> No, we just need to suspend and resume the interrupt controller properly.
> Which we had the technology for, and we actually used to do, but for some
> (incorrect) reason ACPI people thought it should be up to individual
> drivers.

I don't think so - I believe one of the problem cases is where you
have a screaming interrupt caused by an improperly setup device.

Consider the case where you have a shared interrupt line and you're
partially through resuming devices, when one unresumed device (setup
by the BIOS) suddenly starts asserting its interrupt.

The kernel then disables the source. Unfortunately, that was the IRQ
for your USB host, which has your USB keyboard and mouse attached.

--
Russell King
Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/
maintainer of: 2.6 Serial core