Re: [crash, PATCH] Revert "drm/radeon/kms: move radeon KMS on/off switch out of staging."

[Dave Airlie <airlied@gmail.com>]

On Wed, Feb 3, 2010 at 1:46 AM, Ingo Molnar <mingo@elte.hu> wrote:
>
> * Dave Airlie <airlied@gmail.com> wrote:
>
>> On Tue, Feb 2, 2010 at 6:17 PM, Ingo Molnar <mingo@elte.hu> wrote:
>> >
>> > * Dave Airlie <airlied@linux.ie> wrote:
>> >
>> >> > Hi Linus,
>> >> >
>> >> > Please pull the 'drm-linus' branch from
>> >> > ssh://master.kernel.org/pub/scm/linux/kernel/git/airlied/drm-2.6.git drm-linus
>> >> >
>> >>
>> >> I've also added an oops fix I seem to lose off my radar to this tree.
>> >>
>> >> commit 17aafccab4352b422aa01fa6ebf82daff693a5b3
>> >> Author: Michel D??nzer <daenzer@vmware.com>
>> >> Date: ? Fri Jan 22 09:20:00 2010 +0100
>> >>
>> >> ? ? drm/radeon/kms: Fix oops after radeon_cs_parser_init() failure.
>> >
>>
>> Wierd this suggests something else is wrong on that machine can you get me
>> the whole dmesg? I'm guessing some iommu or swiotlb issue.
>
> This box has no known hardware or software problems, just this week it booted
> in excess of 1000 kernels so i'd exclude that angle for now.
>
> I have bisected the crash back to the DRM tree and the crash went away with
> the Kconfig revert i applied - and it got fixed by Jerome's patch. I posted
> my config and i posted the relevant boot log as well. Find below the full
> bootlog as well with vanilla -git (ab65832) and the config. (i dont think it
> matters)
>
>> I've asked Jerome to fix the oops, but really anyone with an old .config
>> won't get hit by this, and we've booted this on quite a lot of machines at
>> this point.
>
> I dont see the commit in yesterday's linux-next. It has very fresh
> timestamps:
>
>  commit f71d0187987e691516cd10c2702f002c0e2f0edc
>  Author:     Dave Airlie <airlied@redhat.com>
>  AuthorDate: Mon Feb 1 11:35:47 2010 +1000
>  Commit:     Dave Airlie <airlied@redhat.com>
>  CommitDate: Mon Feb 1 11:35:47 2010 +1000
>
> What kind of widespread testing could this commit have gotten in the less
> than 24 hours before it hit mainline?
>

Its shipping in a major distro by default, its planned to be shipped in an even
more major distro. Its been boot tested on 1000s of machines by 1000s of ppl.

Your bug isn't anything to do with this commit, its a completely separate issue,
that nobody else has reported before now and Jerome has provided a patch for.

Dave.