From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932378AbdCJBpU (ORCPT ); Thu, 9 Mar 2017 20:45:20 -0500 Received: from mail-qk0-f196.google.com ([209.85.220.196]:34009 "EHLO mail-qk0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932252AbdCJBpR (ORCPT ); Thu, 9 Mar 2017 20:45:17 -0500 Subject: Re: [PATCH v2 net 8/8] net: bcmgenet: decouple flow control from bcmgenet_tx_reclaim To: Doug Berger References: <20170310005850.10808-1-opendmb@gmail.com> <20170310005850.10808-9-opendmb@gmail.com> Cc: pgynther@google.com, jaedon.shin@gmail.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org From: Florian Fainelli Message-ID: <21e3ffb2-cf23-0c55-c5f7-dd711d8332e1@gmail.com> Date: Thu, 9 Mar 2017 17:45:08 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.0 MIME-Version: 1.0 In-Reply-To: <20170310005850.10808-9-opendmb@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 03/09/2017 04:58 PM, Doug Berger wrote: > The bcmgenet_tx_reclaim() function is used to reclaim transmit > resources in different places within the driver. Most of them > should not affect the state of the transmit flow control. > > This commit relocates the logic for waking tx queues based on > freed resources to the napi polling function where it is more > appropriate. > > Fixes: 1c1008c793fa ("net: bcmgenet: add main driver file") > Signed-off-by: Doug Berger Reviewed-by: Florian Fainelli -- Florian