From: Baolu Lu <baolu.lu@linux.intel.com>
To: Nicolin Chen <nicolinc@nvidia.com>, jgg@nvidia.com, kevin.tian@intel.com
Cc: baolu.lu@linux.intel.com, joro@8bytes.org, will@kernel.org,
robin.murphy@arm.com, iommu@lists.linux.dev,
linux-kernel@vger.kernel.org, yi.l.liu@intel.com
Subject: Re: [PATCH 0/2] iommufd: Only enforce_cache_coherency when allocating hwpt
Date: Sat, 21 Oct 2023 09:32:32 +0800 [thread overview]
Message-ID: <2201ae4d-b825-49a5-ba73-c6b310e2969c@linux.intel.com> (raw)
In-Reply-To: <cover.1697848510.git.nicolinc@nvidia.com>
On 2023/10/21 8:37, Nicolin Chen wrote:
> https://lore.kernel.org/linux-iommu/20231020135501.GG3952@nvidia.com/
> The conversation above concluded that a hwpt should only enforce cache
> coherency per device at the stage of its allocation, and it should not
> be changed or updated in the attach/replace routines.
>
> Add two patches dropping the enforce_cache_coherency calls from attach
> and replce routines respectively, since they were introduced with two
> different commits.
>
> Nicolin Chen (2):
> iommufd/device: Drop enforce_cache_coherency in
> iommufd_device_do_replace
> iommufd/device: Drop enforce_cache_coherency in
> iommufd_hw_pagetable_attach
>
> drivers/iommu/iommufd/device.c | 19 ++-----------------
> drivers/iommu/iommufd/hw_pagetable.c | 2 +-
> drivers/iommu/iommufd/iommufd_private.h | 1 -
> 3 files changed, 3 insertions(+), 19 deletions(-)
Hi Kevin and Jason,
With these two fixes, there's no issue in the intel driver any more. Do
I understand it right?
Best regards,
baolu
next prev parent reply other threads:[~2023-10-21 1:32 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-21 0:37 [PATCH 0/2] iommufd: Only enforce_cache_coherency when allocating hwpt Nicolin Chen
2023-10-21 0:37 ` [PATCH 1/2] iommufd/device: Drop enforce_cache_coherency in iommufd_device_do_replace Nicolin Chen
2023-10-21 1:25 ` Baolu Lu
2023-10-23 0:25 ` Nicolin Chen
2023-10-21 0:37 ` [PATCH 2/2] iommufd/device: Drop enforce_cache_coherency in iommufd_hw_pagetable_attach Nicolin Chen
2023-10-21 1:26 ` Baolu Lu
2023-10-21 1:32 ` Baolu Lu [this message]
2023-10-21 16:39 ` [PATCH 0/2] iommufd: Only enforce_cache_coherency when allocating hwpt Jason Gunthorpe
2023-10-23 2:55 ` Tian, Kevin
2023-10-23 3:09 ` Baolu Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2201ae4d-b825-49a5-ba73-c6b310e2969c@linux.intel.com \
--to=baolu.lu@linux.intel.com \
--cc=iommu@lists.linux.dev \
--cc=jgg@nvidia.com \
--cc=joro@8bytes.org \
--cc=kevin.tian@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=nicolinc@nvidia.com \
--cc=robin.murphy@arm.com \
--cc=will@kernel.org \
--cc=yi.l.liu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox