From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S264734AbUGMKOJ (ORCPT ); Tue, 13 Jul 2004 06:14:09 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S264763AbUGMKOJ (ORCPT ); Tue, 13 Jul 2004 06:14:09 -0400 Received: from mx1.redhat.com ([66.187.233.31]:15554 "EHLO mx1.redhat.com") by vger.kernel.org with ESMTP id S264734AbUGMKOH (ORCPT ); Tue, 13 Jul 2004 06:14:07 -0400 From: David Howells In-Reply-To: <20040712111120.2094f089.akpm@osdl.org> References: <20040712111120.2094f089.akpm@osdl.org> To: Andrew Morton Cc: Geert Uytterhoeven , torvalds@osdl.org, linux-kernel@vger.kernel.org Subject: Re: struct_cpy() and kAFS (was: Re: Linux 2.6.8-rc1) User-Agent: EMH/1.14.1 SEMI/1.14.5 (Awara-Onsen) FLIM/1.14.5 (Demachiyanagi) APEL/10.6 Emacs/21.3 (i386-redhat-linux-gnu) MULE/5.0 (SAKAKI) MIME-Version: 1.0 (generated by SEMI 1.14.5 - "Awara-Onsen") Content-Type: text/plain; charset=US-ASCII Date: Tue, 13 Jul 2004 11:14:00 +0100 Message-ID: <2203.1089713640@redhat.com> Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Andrew Morton wrote: > > After this change, all archs need to provide struct_cpy() to make AFS > > compile, while currently only ia32 and amd64 provide it. > > Seems a strange thing to do. Why not rely on the type system? I can't remember why I did it like this. The patch looks okay. Go for it. David