Re: [PATCH] edd (Re: Linux 2.6.8-rc1)

Matt Domsch
2004-07-12T04:49:56Z

[-- Attachment #1: Type: text/plain, Size: 891 bytes --]

On Sun, Jul 11, 2004 at 04:00:19PM -0700, Randy.Dunlap wrote:
> drivers/built-in.o: In function `edd_has_mbr_signature':
> drivers/built-in.o(.text+0x13b84f): undefined reference to `edd'
> drivers/built-in.o(.init.text+0xd39c): more undefined references to `edd' follow
>
> CONFIG_EDD=y on X86o
>
> 'edd' needs to be exported for drivers/firmware/edd.c

I don't think so. It only needs be exported if a module is going to
use it. Since you're building it in, not as a module, it should be
fine.

My own 'make defconfig' on a clean BK tree, enabling CONFIG_EDD=y,
links correctly. Perhaps a make mrproper; make would be in order, as the
deps stage should have caught it for you...

Thanks,
Matt

--
Matt Domsch
Sr. Software Engineer, Lead Engineer
Dell Linux Solutions linux.dell.com & www.dell.com/linux
Linux on Dell mailing lists @ http://lists.us.dell.com

[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]