From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
To: Ajye Huang <ajye_huang@compal.corp-partner.google.com>
Cc: Libin Yang <libin.yang@intel.com>,
"balamurugan . c" <balamurugan.c@intel.com>,
Cezary Rojewski <cezary.rojewski@intel.com>,
Kai Vehmanen <kai.vehmanen@linux.intel.com>,
Bard Liao <yung-chuan.liao@linux.intel.com>,
Takashi Iwai <tiwai@suse.com>,
linux-kernel@vger.kernel.org,
Liam Girdwood <liam.r.girdwood@linux.intel.com>,
Mark Brown <broonie@kernel.org>,
Muralidhar Reddy <muralidhar.reddy@intel.com>,
Ranjani Sridharan <ranjani.sridharan@linux.intel.com>,
Akihiko Odaki <akihiko.odaki@gmail.com>,
ye xingchen <ye.xingchen@zte.com.cn>,
David Lin <CTLIN0@nuvoton.com>,
alsa-devel@alsa-project.org,
Peter Ujfalusi <peter.ujfalusi@linux.intel.com>,
Brent Lu <brent.lu@intel.com>, Yong Zhi <yong.zhi@intel.com>
Subject: Re: [PATCH v1] ASoC: Intel: sof_nau8825: add support for nau8825 with amp nau8318
Date: Fri, 9 Dec 2022 11:31:24 -0600 [thread overview]
Message-ID: <22043956-e18c-9ed6-5091-188ae40f3cd9@linux.intel.com> (raw)
In-Reply-To: <CALprXBayJtWRe9J+q7EahgpXrRy_B-tMAf0KXbDtWa+=4RKyHA@mail.gmail.com>
>> This looks inconsistent with the commit message. There are separate
>> Kconfigs for different codecs.
>>
>> SND_SOC_NAU8315
>> SND_SOC_NAU8825
>>
>> Which is it?
>>
>
> Sorry about confusing you, I think it is better to change the title as
> ASoC: Intel: sof_nau8825: add combination of nau8825 headset codec
> with nau8318 Amp.
Suggested edit:
ASoC: Intel: sof_nau8825: add variant with nau8318 amplifier.
>
> And add some information about Nuvoton chips in the comment message.
> ***
> The nau8315 and nau8318 are both Nuvoton Amp chips. They use the same
> Amp driver nau8315.c. The acpi_device_id for nau8315 is "NVTN2010",
> for nau8318 is "NVTN2012".
That should be added in the commit message please.
>> NAK for this v1. Please clarify which codec you are using and make sure
>> all references are consistent.
>>
>>
>
> I apologize for the unclear comment message, please give me any
> suggestions if needed, and I will send v2 for review.
> thanks.
Ok, makes sense now. Please do include the explanations on 8315/8318
variants, I couldn't figure out what chips were used.
I would also not use the same topology name as a different platform with
another amplifier. I appreciate you trying to reuse when possible, but
it's just better to create a new topology file. That way if you want any
update down the road you can do so, it's more maintainable and risk-free.
next prev parent reply other threads:[~2022-12-09 17:31 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-09 15:05 [PATCH v1] ASoC: Intel: sof_nau8825: add support for nau8825 with amp nau8318 Ajye Huang
2022-12-09 15:52 ` Pierre-Louis Bossart
2022-12-09 17:06 ` Ajye Huang
2022-12-09 17:31 ` Pierre-Louis Bossart [this message]
2022-12-09 17:51 ` Ajye Huang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=22043956-e18c-9ed6-5091-188ae40f3cd9@linux.intel.com \
--to=pierre-louis.bossart@linux.intel.com \
--cc=CTLIN0@nuvoton.com \
--cc=ajye_huang@compal.corp-partner.google.com \
--cc=akihiko.odaki@gmail.com \
--cc=alsa-devel@alsa-project.org \
--cc=balamurugan.c@intel.com \
--cc=brent.lu@intel.com \
--cc=broonie@kernel.org \
--cc=cezary.rojewski@intel.com \
--cc=kai.vehmanen@linux.intel.com \
--cc=liam.r.girdwood@linux.intel.com \
--cc=libin.yang@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=muralidhar.reddy@intel.com \
--cc=peter.ujfalusi@linux.intel.com \
--cc=ranjani.sridharan@linux.intel.com \
--cc=tiwai@suse.com \
--cc=ye.xingchen@zte.com.cn \
--cc=yong.zhi@intel.com \
--cc=yung-chuan.liao@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox