From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751881AbcBEIAG (ORCPT ); Fri, 5 Feb 2016 03:00:06 -0500 Received: from metis.ext.4.pengutronix.de ([92.198.50.35]:53324 "EHLO metis.ext.4.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750847AbcBEIAE (ORCPT ); Fri, 5 Feb 2016 03:00:04 -0500 From: Markus Pargmann To: Dan Streetman Cc: Jens Axboe , nbd-general@lists.sourceforge.net, linux-kernel@vger.kernel.org, Dan Streetman Subject: Re: [PATCH] nbd: ratelimit error msgs after socket close Date: Fri, 05 Feb 2016 08:59:50 +0100 Message-ID: <2208458.aFMEtyXXuv@adelgunde> User-Agent: KMail/4.14.1 (Linux/3.16.0-4-amd64; KDE/4.14.2; x86_64; ; ) In-Reply-To: References: <1452796952-4529-1-git-send-email-dan.streetman@canonical.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="nextPart7215685.8HJYbrjTeb"; micalg="pgp-sha256"; protocol="application/pgp-signature" X-SA-Exim-Connect-IP: 2001:67c:670:100:a61f:72ff:fe68:75ba X-SA-Exim-Mail-From: mpa@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --nextPart7215685.8HJYbrjTeb Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="us-ascii" Hi Dan, On Tuesday, February 02, 2016 12:07:04 PM Dan Streetman wrote: > Hi Markus, >=20 > just checking if you had any comments on this patch? >=20 > On Thu, Jan 14, 2016 at 1:42 PM, Dan Streetman > wrote: > > Make the "Attempted send on closed socket" error messages generated= in > > nbd_request_handler() ratelimited. > > > > When the nbd socket is shutdown, the nbd_request_handler() function= emits > > an error message for every request remaining in its queue. If the = queue > > is large, this will spam a large amount of messages to the log. Th= ere's > > no need for a separate error message for each request, so this patc= h > > ratelimits it. > > > > In the specific case this was found, the system was virtual and the= error > > messages were logged to the serial port, which overwhelmed it. > > > > Fixes: 4d48a542b427 ("nbd: fix I/O hang on disconnected nbds") > > Signed-off-by: Dan Streetman Sorry for the delay. I applied the patch. Thanks, Markus > > --- > > drivers/block/nbd.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/drivers/block/nbd.c b/drivers/block/nbd.c > > index e4c5cc1..c65d41f 100644 > > --- a/drivers/block/nbd.c > > +++ b/drivers/block/nbd.c > > @@ -618,8 +618,8 @@ static void nbd_request_handler(struct request_= queue *q) > > req, req->cmd_type); > > > > if (unlikely(!nbd->sock)) { > > - dev_err(disk_to_dev(nbd->disk), > > - "Attempted send on closed socket\n"= ); > > + dev_err_ratelimited(disk_to_dev(nbd->disk),= > > + "Attempted send on clos= ed socket\n"); > > req->errors++; > > nbd_end_request(nbd, req); > > spin_lock_irq(q->queue_lock); > > -- > > 2.5.0 > > >=20 =2D-=20 Pengutronix e.K. | = | Industrial Linux Solutions | http://www.pengutronix.de/= | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 = | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-555= 5 | --nextPart7215685.8HJYbrjTeb Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part. Content-Transfer-Encoding: 7Bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAABCAAGBQJWtFZ7AAoJEEpcgKtcEGQQLs8P/2HYz97LgvczuTtgry1QPeU7 xW3t7ySYGPyaA1An+79TN7nm22DPapGF0ySW43Ayv5pkROpmAg/7nSuhR3AlkI4J H3M8gLqpKiMUE8MbRwlHnMsJB1Wd3gT7zDIR31l/x0DNUymMFIib5FQsm+hH3yon P1rnp+e7EpErPTkTxzg8kTN5GSSfgu8rCYT1GGosJBmsPUcDLdXxoBS2hDmJFUtO 9W8FwuW2raQhjqRihcw5LezvGbqwpFvOJMJxZNmpma/AhP5D8/4t/fHtn+k/7kjl HJgEEaLVPk2h6TQOv2+tF5WdYqp18AiPnbZreYI6cJoG3aorOfi0LxWJhrkiikr/ 6jAsfEWMIT6X6WCVs+WpMgYX+cznylOZWSCw5PriozYzvI+xRlU8yxSqa2AvOOjC lgtpFB2unsjaOq9u5VUVSBQ3ZgL2moam50d+x/IBBWWdC4s4lWLUSa09RyJmcXml lDelmL3yJtq3K70OXcdfAKeTwPowXKTDoouy5chgQWWmjDtoTEf+3R5hDqssTiun Za1Sow57pzEjJZEFW+0OJkzeXFXk+OK3a3HqFVkJA56/5wU51EANzjptbm8pUare AmHfXEpXz9uTBFea0pD6A5suj5Be1vGf96khrRKNFEs5oePTXRxle5kZCCD8Z1sm n9n35gkGVB1LY3j66oZJ =Jxa+ -----END PGP SIGNATURE----- --nextPart7215685.8HJYbrjTeb--