From: James Calligeros <jcalligeros99@gmail.com>
To: James Calligeros <jcalligeros99@gmail.com>,
Viresh Kumar <viresh.kumar@linaro.org>
Cc: linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org,
nm@ti.com, rafael@kernel.org, sboyd@kernel.org,
vincent.guittot@linaro.org, vireshk@kernel.org
Subject: Re: [PATCH V2 5/5] OPP: decouple dt properties in opp_parse_supplies()
Date: Fri, 04 Nov 2022 15:25:43 +1000 [thread overview]
Message-ID: <2209158.NgBsaNRSFp@makoto> (raw)
In-Reply-To: <20221104050752.67eh54ui2ohbbyni@vireshk-i7>
On Friday, 4 November 2022 3:07:52 PM AEST Viresh Kumar wrote:
> It should happen sequentially.
I noticed the mutexes after I got some sleep :)
> Initialize "ret = 0" in opp_parse_supplies().
>
> Or pick patches from:
>
> git://git.kernel.org/pub/scm/linux/kernel/git/vireshk/pm.git opp/linux-next
>
It didn't even cross my mind that opp_parse_supplies() returning
ret uninitialised was causing the failure further up the chain. Applied
and tested, everything's working as expected now.
> Sorry for the trouble.
This is on me, I should have heeded the compiler warning.
- James
next prev parent reply other threads:[~2022-11-04 5:25 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-03 11:01 [PATCH 0/5] OPP: Allow power/current values without voltage Viresh Kumar
2022-11-03 11:01 ` [PATCH 1/5] dt-bindings: opp: Fix usage of current in microwatt property Viresh Kumar
2022-11-03 11:01 ` [PATCH 2/5] dt-bindings: opp: Fix named " Viresh Kumar
2022-11-03 11:01 ` [PATCH 3/5] OPP: Parse named opp-microwatt property too Viresh Kumar
2022-11-03 11:01 ` [PATCH 4/5] OPP: Simplify opp_parse_supplies() by restructuring it Viresh Kumar
2022-11-03 11:01 ` [PATCH V2 5/5] OPP: decouple dt properties in opp_parse_supplies() Viresh Kumar
2022-11-03 12:24 ` James Calligeros
2022-11-03 13:10 ` Viresh Kumar
2022-11-03 15:23 ` James Calligeros
2022-11-04 5:07 ` Viresh Kumar
2022-11-04 5:25 ` James Calligeros [this message]
2022-11-04 5:28 ` Viresh Kumar
2022-11-04 5:08 ` Viresh Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2209158.NgBsaNRSFp@makoto \
--to=jcalligeros99@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=nm@ti.com \
--cc=rafael@kernel.org \
--cc=sboyd@kernel.org \
--cc=vincent.guittot@linaro.org \
--cc=viresh.kumar@linaro.org \
--cc=vireshk@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox