From: Krzysztof Kozlowski <krzk@kernel.org>
To: Maximilian Luz <luzmaximilian@gmail.com>,
Bjorn Andersson <andersson@kernel.org>
Cc: llvm@lists.linux.dev,
Bartosz Golaszewski <bartosz.golaszewski@linaro.org>,
oe-kbuild-all@lists.linux.dev, linux-kernel@vger.kernel.org,
kernel test robot <lkp@intel.com>
Subject: Re: drivers/firmware/qcom/qcom_scm.c:1652:34: warning: unused variable 'qcom_scm_qseecom_allowlist'
Date: Mon, 20 Nov 2023 19:51:52 +0100 [thread overview]
Message-ID: <220a0b53-14eb-445a-9232-f8df314a29bf@kernel.org> (raw)
In-Reply-To: <f7500671-812d-42ab-a16e-3325e13324ff@gmail.com>
On 20/11/2023 19:19, Maximilian Luz wrote:
>
>
> On 11/19/23 10:13, kernel test robot wrote:
>> tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
>> head: 037266a5f7239ead1530266f7d7af153d2a867fa
>> commit: bdac188ec3c71800dd8419620224ee74ef37732a firmware: qcom: move Qualcomm code into its own directory
>> date: 4 weeks ago
>> config: s390-randconfig-002-20231119 (https://download.01.org/0day-ci/archive/20231119/202311191654.S4wlVUrz-lkp@intel.com/config)
>> compiler: clang version 17.0.0 (https://github.com/llvm/llvm-project.git 4a5ac14ee968ff0ad5d2cc1ffa0299048db4c88a)
>> reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231119/202311191654.S4wlVUrz-lkp@intel.com/reproduce)
>>
>> If you fix the issue in a separate patch/commit (i.e. not just a new version of
>> the same patch/commit), kindly add following tags
>> | Reported-by: kernel test robot <lkp@intel.com>
>> | Closes: https://lore.kernel.org/oe-kbuild-all/202311191654.S4wlVUrz-lkp@intel.com/
>>
>> All warnings (new ones prefixed by >>):
>
> [...]
>
>>>> drivers/firmware/qcom/qcom_scm.c:1652:34: warning: unused variable 'qcom_scm_qseecom_allowlist' [-Wunused-const-variable]
>> 1652 | static const struct of_device_id qcom_scm_qseecom_allowlist[] = {
>> | ^
>
> Any ideas why this is supposedly unused? It should be accessed through
> qcom_scm_qseecom_init() and qcom_scm_qseecom_machine_is_allowed().
> Especially if CONFIG_QCOM_QSEECOM=y.
And in other cases? The bot reports specific failure on specific config.
You have the config for this arch attached, so you can investigate.
Anyway, short look at the code indeed tells it is unused. It's not
referenced anywhere except of_match_node(). I can fix this.
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-11-20 18:52 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-19 9:13 drivers/firmware/qcom/qcom_scm.c:1652:34: warning: unused variable 'qcom_scm_qseecom_allowlist' kernel test robot
2023-11-20 18:19 ` Maximilian Luz
2023-11-20 18:51 ` Krzysztof Kozlowski [this message]
2023-11-20 19:37 ` Maximilian Luz
-- strict thread matches above, loose matches on Subject: below --
2023-12-04 8:56 kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=220a0b53-14eb-445a-9232-f8df314a29bf@kernel.org \
--to=krzk@kernel.org \
--cc=andersson@kernel.org \
--cc=bartosz.golaszewski@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=llvm@lists.linux.dev \
--cc=luzmaximilian@gmail.com \
--cc=oe-kbuild-all@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox