From: Keith Owens <kaos@ocs.com.au>
To: linux-kernel@vger.kernel.org
Subject: [patch] 2.4.0-test10-pre6 remove get_module_symbol MTD/DRM/AGP
Date: Mon, 06 Nov 2000 12:16:12 +1100 [thread overview]
Message-ID: <2214.973473372@kao2.melbourne.sgi.com> (raw)
The get_module_symbol and put_module_symbol functions do not work when
the kernel is compiled with CONFIG_MODVERSIONS. They are a third
mechanism for modules to pass data to each other, the other two are
exported symbols which are resolved at insmod time or via registration
functions.
Because xxx_module_symbol does not work with CONFIG_MODVERSIONS, is
only used by two areas of code (MTD and DRM/AGP) and because Linus
thinks there are no good uses for get_module_symbol[*], this patch
replaces xxx_module_symbol with inter_module registration routines.
[*] http://www.uwsg.indiana.edu/hypermail/linux/kernel/0010.2/0502.html
These routines should only be used for small amounts of data between
two objects. If you need to pass data between more than two objects
then you should seriously think about coding specific registration
functions for those objects instead of overloading generic functions.
The only reason these functions exist is to avoid bloating the kernel
with individual registration functions just for a couple of objects.
The patch hits module.[ch], I already had several outstanding bug fixes
and IA64 module support in my tree, waiting for the code freeze to be
lifted. Since module.[ch] was being hit anyway, I flushed most of my
patch list as part of this patch, these changes are already working in
the IA64 port.
The patch is 66K unzipped, 14K zipped, a bit too big for l-k. Get it
from ftp://ftp.ocs.com.au/pub/2.4.0-test10-pre6-module-symbol.gz. It
fits 2.4.0-test10 with some offsets, although I have not tested the
patch on 2.4.0-test10. MTD says it looks OK, no response from DRM/AGP
after a week, my testing shows it appears to work on DRM/AGP.
Any comments before it goes to Linus?
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/
next reply other threads:[~2000-11-06 1:16 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2000-11-06 1:16 Keith Owens [this message]
2000-11-06 10:58 ` [patch] 2.4.0-test10-pre6 remove get_module_symbol MTD/DRM/AGP David Woodhouse
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2214.973473372@kao2.melbourne.sgi.com \
--to=kaos@ocs.com.au \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox