From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933262AbdBHPi3 (ORCPT ); Wed, 8 Feb 2017 10:38:29 -0500 Received: from mailout4.samsung.com ([203.254.224.34]:58533 "EHLO mailout4.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753928AbdBHPiN (ORCPT ); Wed, 8 Feb 2017 10:38:13 -0500 X-AuditID: b6c32a2e-f79656d0000012f2-2b-589b3b3f3078 From: Bartlomiej Zolnierkiewicz To: Sachin Shukla Cc: Timur Tabi , Tomi Valkeinen , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, sachiniiitm@gmail.com, ravikant.s2@samsung.com, p.shailesh@samsung.com, ashish.kalra@samsung.com, vidushi.koul@samsung.com Subject: Re: [PATCH] Video: fbdev: Remove impossible condition. Date: Wed, 08 Feb 2017 16:37:31 +0100 Message-id: <2214430.FYPozId3LM@amdc3058> User-Agent: KMail/4.13.3 (Linux/3.13.0-96-generic; KDE/4.13.3; x86_64; ; ) In-reply-to: <1478867090-2108-1-git-send-email-sachin.s5@samsung.com> MIME-version: 1.0 Content-transfer-encoding: 7Bit Content-type: text/plain; charset=us-ascii X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrIKsWRmVeSWpSXmKPExsWy7bCmlq699ewIg18feS3uT/vGbrFn70kW i8u75rBZ7JjSymLR1DCb3WLlkvvsFg8WzWW2aHqyntFi/fxbbBZ/L15ic+Dy2DnrLrtH35ZV jB7bF8xm8zh+YzuTx+dNcgGsUVw2Kak5mWWpRfp2CVwZKx6vZinYJVrR/mElewNjg2AXIyeH hICJRM+dtSwQtpjEhXvr2boYuTiEBJYySrxatJ8dwmlnkpg8YyFQhgOso2+BKER8OaNEw55L UEVfGSVmbt7BCjKKTcBKYmL7KkYQW0RAU2LR3adgcWaBNiaJN2vNQWxhAXuJyx3rwOIsAqoS Z9tXg9XzAtW/m/od7CRRAS+JLfvamUBsTgFXiblXrkPVCEr8mHyPBWKmvMS+/VOh5utInD22 jhHkIAmBQ+wS3bsmsENcLSux6QAzxJsuEm+etLJB2MISr45vYYewpSX+Lr3FCGFPZ5TY/lsC Ys5mRolVuydAFVlLHD5+EWoZn0Tv7ydMEPN5JTrahCBKPCTu3LoKDVJHiUXbNoHNFBKYwSix bxnjBEb5WUhemIXkhVlIXljAyLyKUSy1oDg3PbXYtMBYrzgxt7g0L10vOT93EyM44Wjp7WD8 t8D7EKMAB6MSD++NxFkRQqyJZcWVuYcYJTiYlUR4tc1nRwjxpiRWVqUW5ccXleakFh9ilOZg URLnjTKYGCEkkJ5YkpqdmlqQWgSTZeLglGpgVFuy80rX3PRF5qVay30Of1X+fOfmY+6ktf6K OTWJoQeEJq8OW3CIP2JuU36H/7KIiS/uvQlb13UjyGAao703G0vbAR37LXzpl24/d9T6MW3h vyoRadU/98QF5YLcv3N8e6PEs5nR37vUZflLrtijEtwMYnH2RvylO6Or9jGFLUysuWyyM0xW iaU4I9FQi7moOBEAW/6u0jQDAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrCIsWRmVeSWpSXmKPExsVy+t9jAV0769kRBjcaTS3uT/vGbrFn70kW i8u75rBZ7JjSymLR1DCb3WLlkvvsFg8WzWW2aHqyntFi/fxbbBZ/L15ic+Dy2DnrLrtH35ZV jB7bF8xm8zh+YzuTx+dNcgGsUW42GamJKalFCql5yfkpmXnptkqhIW66FkoKeYm5qbZKEbq+ IUFKCmWJOaVAnpEBGnBwDnAPVtK3S3DLWPF4NUvBLtGK9g8r2RsYGwS7GDk4JARMJPoWiHYx cgKZYhIX7q1n62Lk4hASWMoocezIGkYI5yujRMuLEywgVWwCVhIT21cxgtgiApoSi+4+ZQUp YhZoY5JYtmgbWJGwgL3E5Y51rCA2i4CqxNn21WANvEAN76Z+B6sRFfCS2LKvnQnE5hRwlZh7 5TpYjZCAi8TN7SuZIOoFJX5MvgdWzywgL7Fv/1RWCFtLYv3O40wTGAVmISmbhaRsFpKyBYzM qxglUguSC4qT0nON8lLL9YoTc4tL89L1kvNzNzGCY/CZ9A7Gw7vcDzEKcDAq8fBWRMyKEGJN LCuuzD3EKMHBrCTCq20+O0KINyWxsiq1KD++qDQntfgQoynQgxOZpUST84HpIa8k3tDE3MTc 2MDC3NLSxEhJnLdx9rNwIYH0xJLU7NTUgtQimD4mDk6pBkZ+5tq0h6p7TA/c0s3YkvD3q3Ek d/26gK9Tgk+mMrPbOeU8/MHlZ7OwZt3K7U8rzipUbvDkL2DjvKb5tGX1o+9XnMsKPh8VCPm9 VbNIP+sJb+d/S7Ofvz7fPOWspTx9di7nhaD0V2ZrmU0rjrBPXxl/7dizF8ffVIoe9uMLybmv yeTfrRjUZ6DEUpyRaKjFXFScCADnqZPO1wIAAA== X-MTR: 20000000000000000@CPGS X-CMS-MailID: 20170208153734epcas5p1f56516b023b93b77f4bc43d1ac997769 X-Msg-Generator: CA X-Sender-IP: 203.254.230.27 X-Local-Sender: =?UTF-8?B?QmFydGxvbWllaiBab2xuaWVya2lld2ljehtTUlBPTC1LZXJu?= =?UTF-8?B?ZWwgKFRQKRvsgrzshLHsoITsnpAbU2VuaW9yIFNvZnR3YXJlIEVuZ2luZWVy?= X-Global-Sender: =?UTF-8?B?QmFydGxvbWllaiBab2xuaWVya2lld2ljehtTUlBPTC1LZXJu?= =?UTF-8?B?ZWwgKFRQKRtTYW1zdW5nIEVsZWN0cm9uaWNzG1NlbmlvciBTb2Z0d2FyZSBF?= =?UTF-8?B?bmdpbmVlcg==?= X-Sender-Code: =?UTF-8?B?QzEwG0VIURtDMTBDRDAyQ0QwMjczOTI=?= CMS-TYPE: 105P X-HopCount: 7 X-CMS-RootMailID: 20170208153734epcas5p1f56516b023b93b77f4bc43d1ac997769 X-RootMTR: 20170208153734epcas5p1f56516b023b93b77f4bc43d1ac997769 References: <1478867090-2108-1-git-send-email-sachin.s5@samsung.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, [ I'm the new Maintainer of fbdev. ] On Friday, November 11, 2016 05:54:50 PM Sachin Shukla wrote: > From: "Sachin Shukla" > > xoffset and yoffset of struct fb_var_screeninfo are unsigned and so > they can never be less than 0. > > Signed-off-by: Sachin Shukla Thanks, I split the patch on amifb and fsl-diu-fb parts and queued them for 4.11 kernel (+ Timur's ACK has been added to fsl-diu-fb patch). > --- > drivers/video/fbdev/amifb.c | 8 +++----- > drivers/video/fbdev/fsl-diu-fb.c | 9 +-------- > 2 files changed, 4 insertions(+), 13 deletions(-) > > diff --git a/drivers/video/fbdev/amifb.c b/drivers/video/fbdev/amifb.c > index 1d702e1..cc11c60 100644 > --- a/drivers/video/fbdev/amifb.c > +++ b/drivers/video/fbdev/amifb.c > @@ -1484,13 +1484,11 @@ static int ami_decode_var(struct fb_var_screeninfo *var, struct amifb_par *par, > par->xoffset = var->xoffset; > par->yoffset = var->yoffset; > if (par->vmode & FB_VMODE_YWRAP) { > - if (par->xoffset || par->yoffset < 0 || > - par->yoffset >= par->vyres) > + if (par->yoffset >= par->vyres) > par->xoffset = par->yoffset = 0; > } else { > - if (par->xoffset < 0 || > - par->xoffset > upx(16 << maxfmode, par->vxres - par->xres) || > - par->yoffset < 0 || par->yoffset > par->vyres - par->yres) > + if (par->xoffset > upx(16 << maxfmode, par->vxres - par->xres) || > + par->yoffset > par->vyres - par->yres) > par->xoffset = par->yoffset = 0; > } > } else > diff --git a/drivers/video/fbdev/fsl-diu-fb.c b/drivers/video/fbdev/fsl-diu-fb.c > index fe00a07..c48a59e 100644 > --- a/drivers/video/fbdev/fsl-diu-fb.c > +++ b/drivers/video/fbdev/fsl-diu-fb.c > @@ -703,12 +703,6 @@ static int fsl_diu_check_var(struct fb_var_screeninfo *var, > if (var->yres_virtual < var->yres) > var->yres_virtual = var->yres; > > - if (var->xoffset < 0) > - var->xoffset = 0; > - > - if (var->yoffset < 0) > - var->yoffset = 0; > - > if (var->xoffset + info->var.xres > info->var.xres_virtual) > var->xoffset = info->var.xres_virtual - info->var.xres; > > @@ -1254,8 +1248,7 @@ static int fsl_diu_pan_display(struct fb_var_screeninfo *var, > (info->var.yoffset == var->yoffset)) > return 0; /* No change, do nothing */ > > - if (var->xoffset < 0 || var->yoffset < 0 > - || var->xoffset + info->var.xres > info->var.xres_virtual > + if (var->xoffset + info->var.xres > info->var.xres_virtual > || var->yoffset + info->var.yres > info->var.yres_virtual) > return -EINVAL; Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics