From: David Woodhouse <dwmw2@infradead.org>
To: Philip Wang <PXWang@stanford.edu>
Cc: alan@lxorguk.ukuu.org.uk, torvalds@transmeta.com,
linux-kernel@vger.kernel.org,
Dawson Engler <engler@cs.Stanford.EDU>
Subject: Re: [PATCH] drivers/mtd/mtdchar.c
Date: Tue, 22 May 2001 01:15:50 +0100 [thread overview]
Message-ID: <22152.990490550@redhat.com> (raw)
In-Reply-To: <5.0.2.1.2.20010521163446.00a85fa0@pxwang.pobox.stanford.edu>
In-Reply-To: <5.0.2.1.2.20010521163446.00a85fa0@pxwang.pobox.stanford.edu>
PXWang@stanford.edu said:
> There is a bug in mtdchar.c of not freeing memory on error paths.
> databuf is allocated but not freed if copy_from_user fails. The
> addition I made was to kfree databuf before returning -EFAULT.
> Thanks!
Thankyou. I've now committed the fix to my tree and it'll be in the next
merge with Linus, which should hopefully happen quite soon.
--
dwmw2
prev parent reply other threads:[~2001-05-22 0:16 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-05-21 23:38 [PATCH] drivers/mtd/mtdchar.c Philip Wang
2001-05-22 0:15 ` David Woodhouse [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=22152.990490550@redhat.com \
--to=dwmw2@infradead.org \
--cc=PXWang@stanford.edu \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=engler@cs.Stanford.EDU \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@transmeta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox