From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933336AbbI3V7F (ORCPT ); Wed, 30 Sep 2015 17:59:05 -0400 Received: from mout.kundenserver.de ([212.227.126.131]:63925 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933026AbbI3V65 (ORCPT ); Wed, 30 Sep 2015 17:58:57 -0400 From: Arnd Bergmann To: balbi@ti.com Cc: linux-arm-kernel@lists.infradead.org, Tony Lindgren , daniel.lezcano@linaro.org, Linux Kernel Mailing List , tglx@linutronix.de, Linux OMAP Mailing List Subject: Re: [RFC/PATCH 11/11] arm: boot: dts: omap: add missing default status for 32k counter Date: Wed, 30 Sep 2015 23:58:16 +0200 Message-ID: <22213826.1MtkNIZ6W3@wuerfel> User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; ) In-Reply-To: <20150930141209.GB31865@saruman.tx.rr.com> References: <1443559446-26969-1-git-send-email-balbi@ti.com> <4815825.NCBBBMgLGf@wuerfel> <20150930141209.GB31865@saruman.tx.rr.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:Q7FTouAxiqK+isTNVjCXdatzqp6p+UVt8tUOO3/DDUEpo1Zxu2C 4ezZPG4mIYQJUdx421l20JGyZQeiQ+8Z6IROSMXAnJs4VwGLKlaZsxial1eu3AwcqX85rzn egi2lldKghxn4UrnxaWNFKKOLc5wysIxZETZpf+lWr1X2Zit1N0Xudc58cHf/oYKwr3Fe6I vX7tsxd8h1DYhx59+Moaw== X-UI-Out-Filterresults: notjunk:1;V01:K0:BbOa+RbH76s=:TIXliScrqHEj0FI3+jzCor mkk2DYLqZXV9i+HuAb+a7epHoY1tPIxyqwob1pP0pKQPs68r6KNu8GJzbG6jgIp0K9jz9rZMy DVwRMGebbfjeMXKsSmDC8BpogQ1U9G0S8Lh9k+/OLuQA9pfRBFpapOR/3oNcRCE5Q2t+WO+qF 5g82Uhg8fk9x8uTr1NO+m6R0besk1Dfos2eBwGG2lPW4JoWaEbBsvqArS8qV/RHSuSb94ZjH6 c5zOV7CS3md5jax8lkM3mkfawlPM2AOWxdtn5qeAYEpO+2D/Nhcyf7Gy/Z1dGBeWhZ3JpqoP5 DJaOCmW6vhZfhIYdqzl9pRHQ/phCK+ZVDQaAeDtDy9QHo4rNR64rVYk4190aEfHxGiFK/MaKV v6bPeUKxdRSOaiHRPPo28Y5t1s7JezoSvnSGvXeweAnnHWlnOxle9mWO53H9nl4tvQVvLr7dE UpE4qM8r4lDJLdCKl50UXLEMN8Z/Bl7dkK/DRIIyBr5nVJkzlMM85Y4ryXUv7iZlR6FmsUiCy z0aZc0tjCSwBLUiAlz3+fDqwzSFI3MN2jHeDX2Y2gqJVHmb6QQHaz0KZLbGYGyUWq3yOoGceB 4U97+e+D6KulQ0G7ktAZmY9+KBMT9TpZGjUEWX7L9N/4+IjNMQusMnAqahGdU2NnnZ1xL+tm5 kdHl46Iz9CY9HeAW5zMnmKmyCBw5PcWFQ92cy7e3gct1BF//Dn0NjdSyHw2I24qIR0w2HiLN6 gsLmc72dC3k/tUMe Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wednesday 30 September 2015 09:12:09 Felipe Balbi wrote: > On Wed, Sep 30, 2015 at 10:15:25AM +0200, Arnd Bergmann wrote: > > On Tuesday 29 September 2015 15:44:06 Felipe Balbi wrote: > > > All devices should have a default status. Ignoring > > > the arguments if it should be 'okay' or 'disabled' > > > by default, let's set them all the 'disabled' and > > > have boards enable 32k counter. > > > > > > Signed-off-by: Felipe Balbi > > > > > > > The patch looks good, but the description is slightly incorrect: > > There is no reason to list "status='okay'" other than overriding > > the 'disabled' status. > > > > I'd phrase it something like: > > > > "We want the use of the 32k counter to be a per-board setting, > > so let's disable it by default in each dtsi file and override the > > setting in the boards. Any board that does not wire up the counter > > should leave it disabled". > > > > However, if you really want all boards to provide the counter all > > the time, I'd argue that we're better off dropping this patch. We > > use the status="disabled" trick for anything that may or may not > > be working based on the board design, but things that are present > > everywhere don't need this. > > okay, so here's the thing. While fiddling with the 32k counter, I noticed > that even though there was no status listed, the thing still initializes > fine. However, when moving 32k to drivers/clocksource and using > CLOCKSOURCE_OF_DECLARE(), 32k would *NOT* probe unless I had an explicit > status = "okay" in DT. Very strange, that sounds like a bug in the clocksource probe code. Can you check how this happens? Arnd