From: David Howells <dhowells@redhat.com>
To: Dominique Martinet <asmadeus@codewreck.org>
Cc: dhowells@redhat.com, Arnd Bergmann <arnd@kernel.org>,
Arnd Bergmann <arnd@arndb.de>,
Eric Van Hensbergen <ericvh@gmail.com>,
Latchesar Ionkov <lucho@ionkov.net>,
Jeff Layton <jlayton@kernel.org>,
v9fs-developer@lists.sourceforge.net,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] 9p: fix unused-variable warning
Date: Sat, 18 Dec 2021 13:51:36 +0000 [thread overview]
Message-ID: <2222224.1639835496@warthog.procyon.org.uk> (raw)
In-Reply-To: <Yb3AbFhc9ApdHpcA@codewreck.org>
Dominique Martinet <asmadeus@codewreck.org> wrote:
> David since then fixed the warning differently in v2 of the patch (he
> moved the fscache_note_page_release() out of the ifdef), so I won't do
> anything with this even if in principle I tend to agree that
> if(IS_ENABLED()) lead to better compiler coverage
Yeah, fscache_note_page_release() compiles out in such a case because
v9fs_inode_cookie() becomes unconditionally NULL if it's disabled.
If you want me to do something different, can you give me an incremental patch
to merge into mine?
David
prev parent reply other threads:[~2021-12-18 13:51 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-03 18:58 [PATCH] 9p: fix unused-variable warning Arnd Bergmann
[not found] ` <YaqwdNGlZDBDcg5R@codewreck.org>
2021-12-18 11:05 ` Dominique Martinet
2021-12-18 13:51 ` David Howells [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2222224.1639835496@warthog.procyon.org.uk \
--to=dhowells@redhat.com \
--cc=arnd@arndb.de \
--cc=arnd@kernel.org \
--cc=asmadeus@codewreck.org \
--cc=ericvh@gmail.com \
--cc=jlayton@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lucho@ionkov.net \
--cc=v9fs-developer@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox