From: Arnd Bergmann <arnd@arndb.de>
To: Baoyou Xie <baoyou.xie@linaro.org>
Cc: dan.j.williams@intel.com, vinod.koul@intel.com,
dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org,
xie.baoyou@zte.com.cn
Subject: Re: [PATCH 2/3] dmaengine: pxa_dma: add function declaration
Date: Sat, 24 Sep 2016 11:05:45 +0200 [thread overview]
Message-ID: <2223993.4ZykH5Lksh@wuerfel> (raw)
In-Reply-To: <1474693119-15939-1-git-send-email-baoyou.xie@linaro.org>
On Saturday, September 24, 2016 12:58:39 PM CEST Baoyou Xie wrote:
> We get 1 warning when building kernel with W=1:
> drivers/dma/pxa_dma.c:1525:5: warning: no previous prototype for 'pxad_toggle_reserved_channel' [-Wmissing-prototypes]
>
> In fact, this function is undeclared in any header files.
>
> So this patch adds function declaration in include/linux/dma/pxa-dma.h.
>
> Signed-off-by: Baoyou Xie <baoyou.xie@linaro.org>
>
No, this is wrong: the function was originally introduced as the
interface between drivers/dma/pxa_dma.c and arch/arm/plat-pxa/dma.c,
but the latter file has been removed recently, along with the
declaration.
Please remove the function as well now.
In the future, when you find an exported function without a
declaration, don't assume that it should be declared, but instead
look up the git history of that identifier to see if the users
were all removed, or if it was perhaps never used.
Arnd
prev parent reply other threads:[~2016-09-24 9:06 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-24 4:58 [PATCH 2/3] dmaengine: pxa_dma: add function declaration Baoyou Xie
2016-09-24 9:05 ` Arnd Bergmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2223993.4ZykH5Lksh@wuerfel \
--to=arnd@arndb.de \
--cc=baoyou.xie@linaro.org \
--cc=dan.j.williams@intel.com \
--cc=dmaengine@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=vinod.koul@intel.com \
--cc=xie.baoyou@zte.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox