From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1761643AbcIXJGO (ORCPT ); Sat, 24 Sep 2016 05:06:14 -0400 Received: from mout.kundenserver.de ([212.227.17.10]:51468 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758169AbcIXJGJ (ORCPT ); Sat, 24 Sep 2016 05:06:09 -0400 From: Arnd Bergmann To: Baoyou Xie Cc: dan.j.williams@intel.com, vinod.koul@intel.com, dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org, xie.baoyou@zte.com.cn Subject: Re: [PATCH 2/3] dmaengine: pxa_dma: add function declaration Date: Sat, 24 Sep 2016 11:05:45 +0200 Message-ID: <2223993.4ZykH5Lksh@wuerfel> User-Agent: KMail/5.1.3 (Linux/4.4.0-34-generic; KDE/5.18.0; x86_64; ; ) In-Reply-To: <1474693119-15939-1-git-send-email-baoyou.xie@linaro.org> References: <1474693119-15939-1-git-send-email-baoyou.xie@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:OYZjU5spHgSbwkJtnsUpb2MOs1hsrg5aHbgHMiVICHTaf6CpqiY ph7S2JWPLXZD4qXrIjtKczAgBe7MNwHNr7bkD3DSBP2mOB5rdqswseW4pOV3y5Rjl2+xEoU QPJlQwaDJ6Bbi78sxUP0HcsZ8gymeUUg6nmopPtZAqpWIEA8N8ze/jFL4jeGOG8/4cdhIek nS3aCnoRhUwIIh1rnA9oA== X-UI-Out-Filterresults: notjunk:1;V01:K0:qJiR6tI9K98=:khK2KcZ3pP/c3rsGVIeCfn tbRou9SdvLhGo6+9wOs3JS9g36LmV9bPyuBvlbS2/ZBPCjFTX48BDBKj7zOGfezcXWlPhB8j5 eUCvBJA5JOEgYJdCf4RTUa42x/4jvY5UuIvxYbyF9EHQepD9c9ius1yWPYVUY5spUuKW6+08q Oy8ui6OP84Rlit00vDgXiJ5mW2GJRalkMse3Bm+eO52U17OFLVpzhnbRZgXJDCyzS8FDERZzH juZiRAaBvo6o6zIwENGIVao8MV01855BiKvQcCp/sK4cF1jDACsFoFthruvlSZMulyCxzsFJv CYlf6J5q0/jnt3IMARv50tkzvwxA0XGiEzR3pxrU8ygKXbw2rAZJzRN/nvN84nbO/3mDHqMoP nNar//ecLo7yXhHWOWjMqZlBTMpvYtcbZMcHBrZXL084S16O5NPjhqDa2nMko5dyXGzHi8s88 d7qkicFoXjzFc7fxqry8skiy588kyjt7QoOehBRpmj6OlX9DPhUmOs177JYChpyIL1w1qMdmf hlcJTD6uLJZ4JvghE5i6pf6notO7jE1lv2vM6adbJCOH7gF6FhopKYEk09SPo6VZKCC9Absfk zNcq+QN1DGpM3mFDb2DeV01f301LWH/EPSYQrgNSuocQyT+ugicZFCteWkqKtjxf7PDaEFIkp ooBkKmqH7ZLhwKiZa1E20b5iMrdzTd7VxlJ7sL5BeyXwrw3H4EvfhzfTfEh00fyhov34pX6on hvvEI5L1yZEN8JfD Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Saturday, September 24, 2016 12:58:39 PM CEST Baoyou Xie wrote: > We get 1 warning when building kernel with W=1: > drivers/dma/pxa_dma.c:1525:5: warning: no previous prototype for 'pxad_toggle_reserved_channel' [-Wmissing-prototypes] > > In fact, this function is undeclared in any header files. > > So this patch adds function declaration in include/linux/dma/pxa-dma.h. > > Signed-off-by: Baoyou Xie > No, this is wrong: the function was originally introduced as the interface between drivers/dma/pxa_dma.c and arch/arm/plat-pxa/dma.c, but the latter file has been removed recently, along with the declaration. Please remove the function as well now. In the future, when you find an exported function without a declaration, don't assume that it should be declared, but instead look up the git history of that identifier to see if the users were all removed, or if it was perhaps never used. Arnd