* [PATCH] [TRIVIAL] IBM Akebono: Remove select of IBM_EMAC_RGMII_WOL
@ 2014-11-03 9:52 Paul Bolle
2014-12-22 10:14 ` Paul Bolle
0 siblings, 1 reply; 4+ messages in thread
From: Paul Bolle @ 2014-11-03 9:52 UTC (permalink / raw)
To: Jiri Kosina
Cc: Valentin Rothberg, Alistair Popple, Benjamin Herrenschmidt,
linux-kernel
Commit 2a2c74b2efcb ("IBM Akebono: Add the Akebono platform") added a
select of IBM_EMAC_RGMII_WOL. But that Kconfig symbol isn't (yet) part
of the tree. So this select has been a nop since that commit was
included in v3.16-rc1.
The code to add this symbol is not included in next-20141103. So let's
remove this select. It can be readded when that symbol is actually added
to the tree.
Signed-off-by: Paul Bolle <pebolle@tiscali.nl>
Cc: Alistair Popple <alistair@popple.id.au>
---
Untested. Done on top of next-20141103.
Third time's a charm? First raised in
https://lkml.org/lkml/2014/5/1/106 . Reminder sent in
https://lkml.org/lkml/2014/9/4/645 . I'm not aware of any news on this
front, so this trivial patch seems reasonable now.
A patch to readd this select could be added - if people still care about
it, that is - in the series that adds this symbol. A web search suggests
Alistair takes care of that series, so Alistair gets a Cc: here.
arch/powerpc/platforms/44x/Kconfig | 1 -
1 file changed, 1 deletion(-)
diff --git a/arch/powerpc/platforms/44x/Kconfig b/arch/powerpc/platforms/44x/Kconfig
index d2ac1c116454..5538e57c36c1 100644
--- a/arch/powerpc/platforms/44x/Kconfig
+++ b/arch/powerpc/platforms/44x/Kconfig
@@ -214,7 +214,6 @@ config AKEBONO
select ETHERNET
select NET_VENDOR_IBM
select IBM_EMAC_EMAC4
- select IBM_EMAC_RGMII_WOL
select USB if USB_SUPPORT
select USB_OHCI_HCD_PLATFORM if USB_OHCI_HCD
select USB_EHCI_HCD_PLATFORM if USB_EHCI_HCD
--
1.9.3
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] [TRIVIAL] IBM Akebono: Remove select of IBM_EMAC_RGMII_WOL
2014-11-03 9:52 [PATCH] [TRIVIAL] IBM Akebono: Remove select of IBM_EMAC_RGMII_WOL Paul Bolle
@ 2014-12-22 10:14 ` Paul Bolle
2014-12-22 22:48 ` Alistair Popple
0 siblings, 1 reply; 4+ messages in thread
From: Paul Bolle @ 2014-12-22 10:14 UTC (permalink / raw)
To: Jiri Kosina
Cc: Valentin Rothberg, Alistair Popple, Benjamin Herrenschmidt,
linux-kernel
Hi Jiri,
On Mon, 2014-11-03 at 10:52 +0100, Paul Bolle wrote:
> Commit 2a2c74b2efcb ("IBM Akebono: Add the Akebono platform") added a
> select of IBM_EMAC_RGMII_WOL. But that Kconfig symbol isn't (yet) part
> of the tree. So this select has been a nop since that commit was
> included in v3.16-rc1.
>
> The code to add this symbol is not included in next-20141103. So let's
> remove this select. It can be readded when that symbol is actually added
> to the tree.
>
> Signed-off-by: Paul Bolle <pebolle@tiscali.nl>
> Cc: Alistair Popple <alistair@popple.id.au>
> ---
> Untested. Done on top of next-20141103.
>
> Third time's a charm? First raised in
> https://lkml.org/lkml/2014/5/1/106 . Reminder sent in
> https://lkml.org/lkml/2014/9/4/645 . I'm not aware of any news on this
> front, so this trivial patch seems reasonable now.
>
> A patch to readd this select could be added - if people still care about
> it, that is - in the series that adds this symbol. A web search suggests
> Alistair takes care of that series, so Alistair gets a Cc: here.
This select of IBM_EMAC_RGMII_WOL still shows up in next-20141221 and
v3.19-rc1. Did you have a chance to look at this patch?
> arch/powerpc/platforms/44x/Kconfig | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/arch/powerpc/platforms/44x/Kconfig b/arch/powerpc/platforms/44x/Kconfig
> index d2ac1c116454..5538e57c36c1 100644
> --- a/arch/powerpc/platforms/44x/Kconfig
> +++ b/arch/powerpc/platforms/44x/Kconfig
> @@ -214,7 +214,6 @@ config AKEBONO
> select ETHERNET
> select NET_VENDOR_IBM
> select IBM_EMAC_EMAC4
> - select IBM_EMAC_RGMII_WOL
> select USB if USB_SUPPORT
> select USB_OHCI_HCD_PLATFORM if USB_OHCI_HCD
> select USB_EHCI_HCD_PLATFORM if USB_EHCI_HCD
Thanks,
Paul Bolle
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] [TRIVIAL] IBM Akebono: Remove select of IBM_EMAC_RGMII_WOL
2014-12-22 10:14 ` Paul Bolle
@ 2014-12-22 22:48 ` Alistair Popple
2014-12-23 0:31 ` Michael Ellerman
0 siblings, 1 reply; 4+ messages in thread
From: Alistair Popple @ 2014-12-22 22:48 UTC (permalink / raw)
To: Paul Bolle, Jiri Kosina
Cc: Valentin Rothberg, Benjamin Herrenschmidt, linux-kernel,
linuxppc-dev, Michael Ellerman
Hi Paul,
These days I've been made maintainer of the PPC4XX tree so maybe adding Acked-
by: Alistair Popple <alistair@popple.id.au> might help?
Jiri, if you would rather this go via the main PPC tree please let us know and
we'll see if Michael Ellerman (added to CC) would be willing to take it (he
has taken over most of the day to day maintenance of the PPC tree). Thanks!
Regards,
Alistair
On Mon, 22 Dec 2014 11:14:33 Paul Bolle wrote:
> Hi Jiri,
>
> On Mon, 2014-11-03 at 10:52 +0100, Paul Bolle wrote:
> > Commit 2a2c74b2efcb ("IBM Akebono: Add the Akebono platform") added a
> > select of IBM_EMAC_RGMII_WOL. But that Kconfig symbol isn't (yet) part
> > of the tree. So this select has been a nop since that commit was
> > included in v3.16-rc1.
> >
> > The code to add this symbol is not included in next-20141103. So let's
> > remove this select. It can be readded when that symbol is actually added
> > to the tree.
> >
> > Signed-off-by: Paul Bolle <pebolle@tiscali.nl>
> > Cc: Alistair Popple <alistair@popple.id.au>
> > ---
> > Untested. Done on top of next-20141103.
> >
> > Third time's a charm? First raised in
> > https://lkml.org/lkml/2014/5/1/106 . Reminder sent in
> > https://lkml.org/lkml/2014/9/4/645 . I'm not aware of any news on this
> > front, so this trivial patch seems reasonable now.
> >
> > A patch to readd this select could be added - if people still care about
> > it, that is - in the series that adds this symbol. A web search suggests
> > Alistair takes care of that series, so Alistair gets a Cc: here.
>
> This select of IBM_EMAC_RGMII_WOL still shows up in next-20141221 and
> v3.19-rc1. Did you have a chance to look at this patch?
>
> > arch/powerpc/platforms/44x/Kconfig | 1 -
> > 1 file changed, 1 deletion(-)
> >
> > diff --git a/arch/powerpc/platforms/44x/Kconfig
> > b/arch/powerpc/platforms/44x/Kconfig index d2ac1c116454..5538e57c36c1
> > 100644
> > --- a/arch/powerpc/platforms/44x/Kconfig
> > +++ b/arch/powerpc/platforms/44x/Kconfig
> > @@ -214,7 +214,6 @@ config AKEBONO
> >
> > select ETHERNET
> > select NET_VENDOR_IBM
> > select IBM_EMAC_EMAC4
> >
> > - select IBM_EMAC_RGMII_WOL
> >
> > select USB if USB_SUPPORT
> > select USB_OHCI_HCD_PLATFORM if USB_OHCI_HCD
> > select USB_EHCI_HCD_PLATFORM if USB_EHCI_HCD
>
> Thanks,
>
>
> Paul Bolle
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] [TRIVIAL] IBM Akebono: Remove select of IBM_EMAC_RGMII_WOL
2014-12-22 22:48 ` Alistair Popple
@ 2014-12-23 0:31 ` Michael Ellerman
0 siblings, 0 replies; 4+ messages in thread
From: Michael Ellerman @ 2014-12-23 0:31 UTC (permalink / raw)
To: Paul Bolle
Cc: Jiri Kosina, Valentin Rothberg, Benjamin Herrenschmidt,
linux-kernel, linuxppc-dev, Alistair Popple
On Tue, 2014-12-23 at 09:48 +1100, Alistair Popple wrote:
> Hi Paul,
>
> These days I've been made maintainer of the PPC4XX tree so maybe adding Acked-
> by: Alistair Popple <alistair@popple.id.au> might help?
>
> Jiri, if you would rather this go via the main PPC tree please let us know and
> we'll see if Michael Ellerman (added to CC) would be willing to take it (he
> has taken over most of the day to day maintenance of the PPC tree). Thanks!
It never went to linuxppc as far as I can see, though I am happy to take it.
Although it is a trivial patch I'd still rather you CC'ed us on patches to
arch/powerpc.
cheers
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2014-12-23 0:31 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-11-03 9:52 [PATCH] [TRIVIAL] IBM Akebono: Remove select of IBM_EMAC_RGMII_WOL Paul Bolle
2014-12-22 10:14 ` Paul Bolle
2014-12-22 22:48 ` Alistair Popple
2014-12-23 0:31 ` Michael Ellerman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox