From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1754007AbdEHJOX (ORCPT <rfc822;w@1wt.eu>);
        Mon, 8 May 2017 05:14:23 -0400
Received: from mailout2.samsung.com ([203.254.224.25]:42757 "EHLO
        mailout2.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751727AbdEHJOM (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 8 May 2017 05:14:12 -0400
X-AuditID: b6c32a2d-f792a6d0000055a1-c8-591036e1b798
From: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
To: myungjoo.ham@samsung.com
Cc: Dan Carpenter <dan.carpenter@oracle.com>,
        "lgirdwood@gmail.com" <lgirdwood@gmail.com>,
        "broonie@kernel.org" <broonie@kernel.org>,
        Chanwoo Choi <cw00.choi@samsung.com>,
        "krzk@kernel.org" <krzk@kernel.org>,
        "kernel-janitors@vger.kernel.org" <kernel-janitors@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] regulator: max8997/8966: fix charger cv voltage set bug
Date: Mon, 08 May 2017 11:14:06 +0200
Message-id: <2225534.LTs3WEvGn7@amdc3058>
User-Agent: KMail/4.13.3 (Linux/3.13.0-96-generic; KDE/4.13.3; x86_64; ; )
In-reply-to: <20170508054544epcms1p6d3d429e6f062e987adf72fc2c04ed159@epcms1p6>
MIME-version: 1.0
Content-transfer-encoding: 7Bit
Content-type: text/plain; charset="us-ascii"
X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprBKsWRmVeSWpSXmKPExsWy7bCmuu5DM4FIg+2rDCymPnzCZnH9y3NW
        i9f/prNYbL0lbXH+/AZ2i29XOpgsLu+aw2Zxu3EFmwOHx85Zd9k9Nq3qZPP4+PQWi0ffllWM
        Hp83yQWwRnHZpKTmZJalFunbJXBlfLl9nr3gB0vF2Z8djA2MzSxdjJwcEgImEnNO72WHsMUk
        Ltxbz9bFyMUhJLCUUeLXwnUsEM5nRolLr9uZYTqWzV0GVbWDUeLi3ZvMEM5XRom2rZfBZrEJ
        WElMbF/FCGKLCMhIXN24HWwUs8BtJomD34+BjRIW8JHY+PE9K4jNIqAqMX1qAxuIzSugKfHh
        eyfYIFEBL4kt+9qZQGxOAT+JjZefs0LUCEr8mHwP7AlmAXmJffunskLYOhJnj61jBFkmITCP
        XaL3wyugZg4gR1Zi0wGoF1wkzt76Aw0AYYlXx7dAA0BKortjFpQ9nVFi+28JiDmbGSVW7Z4A
        lbCWOHz8ItQyPone30+g5vNKdLQJQZR4SBy/8YoNIuwosX+DJiSADjBK7P31kXUCo/wsJC/M
        QvLCLCQvLGBkXsUollpQnJueWmxaYKRXnJhbXJqXrpecn7uJEZxetHR3MH5Z4H2IUYCDUYmH
        N4JJIFKINbGsuDL3EKMEB7OSCO9rQ6AQb0piZVVqUX58UWlOavEhRmkOFiVxXvWV1yKEBNIT
        S1KzU1MLUotgskwcnFINjOzzisQ/nLETtt56abYhk7vd25lLL+2f/ebRkkevX+yrfLbGrfp+
        SNmPenP5/JPen+ISOyJmV3Wq6bvlLH94NMV+Qy7v9mon9tccEqs8+Ovmiblw12R/mdLIP3eK
        KtcLvfefTCSFluQJBOyz55y+KyPieG5Oplnmnie/3X5tyZB5f+bJD9PTv5RYijMSDbWYi4oT
        AXwgsUcrAwAA
X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrLIsWRmVeSWpSXmKPExsVy+t9jAd2HZgKRBgvPi1lMffiEzeL6l+es
        Fq//TWex2HpL2uL8+Q3sFt+udDBZXN41h83iduMKNgcOj52z7rJ7bFrVyebx8ektFo++LasY
        PT5vkgtgjXKzyUhNTEktUkjNS85PycxLt1UKDXHTtVBSyEvMTbVVitD1DQlSUihLzCkF8owM
        0ICDc4B7sJK+XYJbxpfb59kLfrBUnP3ZwdjA2MzSxcjJISFgIrFs7jI2CFtM4sK99UA2F4eQ
        wDZGiXWvpzJDOF8ZJVZ8PsUIUsUmYCUxsX0VmC0iICNxdeN2FpAiZoG7TBJ7D3UzgSSEBXwk
        Nn58zwpiswioSkyf2gC2gldAU+LD9052EFtUwEtiy752sHpOAT+JjZefs0JsO8Ao0TSvjxGi
        QVDix+R7YLcyC8hL7Ns/lRXC1pJYv/M40wRGgVlIymYhKZuFpGwBI/MqRq7UguLc9NxiowKj
        TYzAqNp2WCtgB2PTuehDjAIcjEo8vBPm8kcKsSaWFVfmHmKU4GBWEuF9bSgQKcSbklhZlVqU
        H19UmpNafIjRFOinicxSosn5wIjPK4k3NLE0MjEwMzM0MjA2UxLnnRD4JUJIID2xJDU7NbUg
        tQimj4mDU6qBsVVgqffC9d+z1y0KX2Ggs/xM9qVvXYKWm9f6FafsfuX/Qi2jc1JhcFCY1Rld
        Xnn5xXqr5VWsnAsnyyz7t23/pqLNcjN36Js2lyg+r7br9FNK2p60sk9op7ztswcdE+ZXl21f
        b/P4YQfX5p8bjz62uSjyVGvDad118y5OsdoRXarwZfGtw8nSdkosxRmJhlrMRcWJAGam+hnA
        AgAA
X-MTR: 20000000000000000@CPGS
X-CMS-MailID: 20170508091409epcas5p3969661c3468279a9734cdf3291854e0c
X-Msg-Generator: CA
X-Sender-IP: 182.195.42.80
X-Local-Sender: =?UTF-8?B?QmFydGxvbWllaiBab2xuaWVya2lld2ljehtTUlBPTC1LZXJu?=
        =?UTF-8?B?ZWwgKFRQKRvsgrzshLHsoITsnpAbU2VuaW9yIFNvZnR3YXJlIEVuZ2luZWVy?=
X-Global-Sender: =?UTF-8?B?QmFydGxvbWllaiBab2xuaWVya2lld2ljehtTUlBPTC1LZXJu?=
        =?UTF-8?B?ZWwgKFRQKRtTYW1zdW5nIEVsZWN0cm9uaWNzG1NlbmlvciBTb2Z0d2FyZSBF?=
        =?UTF-8?B?bmdpbmVlcg==?=
X-Sender-Code: =?UTF-8?B?QzEwG0VIURtDMTBDRDAyQ0QwMjczOTI=?=
CMS-TYPE: 105P
X-CMS-RootMailID: 20170428141118epcas2p42c864cf574cc6fa3ffedbef22029e3ef
X-RootMTR: 20170428141118epcas2p42c864cf574cc6fa3ffedbef22029e3ef
References: <20170428141103.llm5t44o2vf46y5c@mwanda>
        <CGME20170428141118epcas2p42c864cf574cc6fa3ffedbef22029e3ef@epcms1p6>
        <20170508054544epcms1p6d3d429e6f062e987adf72fc2c04ed159@epcms1p6>
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Monday, May 08, 2017 05:45:44 AM MyungJoo Ham wrote:
> 
> When min charger-CV is <= 4.0V and max charger-CV is >= 4.0V,
> we can use 4.00V as CV (register value = 0x1).`
> 
> The original code had a typo that wrote ">=" (max_uV >= 4000000),
> which should've been "<", which is not necessary anyway
> as mentioned by Dan Carpenter.
> 
> Reported-By: Dan Carpenter <dan.carpenter@oracle.com>
> Signed-off-by: MyungJoo Ham <myungjoo.ham@samsung.com>

Reviewed-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>

Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics