From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934890AbcIFXde (ORCPT ); Tue, 6 Sep 2016 19:33:34 -0400 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:38809 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S933190AbcIFXda (ORCPT ); Tue, 6 Sep 2016 19:33:30 -0400 X-IBM-Helo: d24dlp02.br.ibm.com X-IBM-MailFrom: bauerman@linux.vnet.ibm.com X-IBM-RcptTo: linux-kernel@vger.kernel.org;linux-omap@vger.kernel.org From: Thiago Jung Bauermann To: Tony Lindgren Cc: Andrew Morton , Eric Biederman , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org, Russell King - ARM Linux , Dave Young , Mimi Zohar , linux-ima-devel@lists.sourceforge.net, linuxppc-dev@lists.ozlabs.org Subject: Re: Kexec regression in next-20160906 Date: Tue, 06 Sep 2016 20:33:20 -0300 User-Agent: KMail/4.14.3 (Linux/3.13.0-95-generic; KDE/4.14.13; x86_64; ; ) In-Reply-To: <20160906220936.4txqzodkgknhjiyh@atomide.com> References: <20160906220936.4txqzodkgknhjiyh@atomide.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 16090623-0028-0000-0000-0000013DDFB3 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 16090623-0029-0000-0000-0000140571EA Message-Id: <2229914.bQjEFCIRgO@hactar> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2016-09-06_10:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=0 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1604210000 definitions=main-1609060361 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello Tony, Am Dienstag, 06 September 2016, 15:09:37 schrieb Tony Lindgren: > Looks like commit 5c01cdd2d4bc ("kexec_file: allow skipping checksum > calculation for some segments") makes next-20160916 stop working for > me at least on ARM. > > I now get "kexec_load failed: Invalid argument error" on loading the > new kernel to memory with kexec -l. > > Reverting the following two commits makes things work for me again: > > d2bf993afdf1 ("kexec_file: add mechanism to update kexec segments") > 5c01cdd2d4bc ("kexec_file: allow skipping checksum calculation for > some segments") Thanks for reporting the problem and finding the commit that caused it. The only thing in commit 5c01cdd2d4bc which can affect kexec_load is the fact that struct kexec_segment has a new member. This is probably breaking the ABI on ARM, then. I verified that kexec_load kept working on ppc64le with a kexec binary compiled with the original struct kexec_segment definition, but apparently I got lucky. I'll prepare a new version of the kexec buffer hand-over series which doesn't touch struct kexec_segment. -- []'s Thiago Jung Bauermann IBM Linux Technology Center