From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752692AbcAQTh0 (ORCPT ); Sun, 17 Jan 2016 14:37:26 -0500 Received: from gloria.sntech.de ([95.129.55.99]:34053 "EHLO gloria.sntech.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752556AbcAQThZ (ORCPT ); Sun, 17 Jan 2016 14:37:25 -0500 From: Heiko Stuebner To: Caesar Wang Cc: linux-rockchip@lists.infradead.org, leozwang@google.com, Mark Brown , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, keescook@google.com Subject: Re: [PATCH v3 7/9] ARM: dts: rockchip: add the sdmmc for kylin board Date: Sun, 17 Jan 2016 20:37:17 +0100 Message-ID: <2230942.JkKsuulFEe@phil> User-Agent: KMail/4.14.10 (Linux/4.3.0-1-amd64; KDE/4.14.14; x86_64; ; ) In-Reply-To: <1452865796-23527-8-git-send-email-wxt@rock-chips.com> References: <1452865796-23527-1-git-send-email-wxt@rock-chips.com> <1452865796-23527-8-git-send-email-wxt@rock-chips.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am Freitag, 15. Januar 2016, 21:49:54 schrieb Caesar Wang: > Although We can add the sdmmc node, shouldn't enable it. > Since the sdmmc is reusing the same pin with uart2. > Unfortunately, the uart2 is used by the debug port, so that will cause > the debug information can't display on console if enabling the sdmmc. > > As we have supported the sdmmc (sd card) on hardware for kylin board. > So, maybe we can have the sdmmc node in kylin dts, not to enable it. > > Anyway, you only need add the okay status if someone want to enable the > sdmmc. > > e.g. > if you use the adb to debug with android os. > You can add the > status = "okay" to enable the sdmmc for sd card working. > The defauly status is disabling it. > > Signed-off-by: Caesar Wang applied to my dts32 branch for 4.6 Thanks Heiko