From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1030310AbcIZJBW (ORCPT ); Mon, 26 Sep 2016 05:01:22 -0400 Received: from bhuna.collabora.co.uk ([46.235.227.227]:40695 "EHLO bhuna.collabora.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965343AbcIZJBU (ORCPT ); Mon, 26 Sep 2016 05:01:20 -0400 Subject: Re: [PATCH v5 2/2] usb: chipidea: imx: Add binding to disable USB 60Mhz clock To: Rob Herring References: <1474448827-8354-1-git-send-email-fabien.lahoudere@collabora.co.uk> <1474448827-8354-3-git-send-email-fabien.lahoudere@collabora.co.uk> <20160923194728.GA7120@rob-hp-laptop> Cc: Peter.Chen@nxp.com, gregkh@linuxfoundation.org, linux-usb@vger.kernel.org, mark.rutland@arm.com, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org From: Fabien Lahoudere Message-ID: <22314d5c-e19b-02fb-d794-23da2e03fe07@collabora.co.uk> Date: Mon, 26 Sep 2016 11:00:53 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Icedove/45.2.0 MIME-Version: 1.0 In-Reply-To: <20160923194728.GA7120@rob-hp-laptop> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On 23/09/16 21:47, Rob Herring wrote: > On Wed, Sep 21, 2016 at 11:07:07AM +0200, Fabien Lahoudere wrote: >> This binding allow to disable the internal 60Mhz clock for USB host2 or >> host3. >> >> Signed-off-by: Fabien Lahoudere >> --- >> Documentation/devicetree/bindings/usb/ci-hdrc-usb2.txt | 1 + >> drivers/usb/chipidea/ci_hdrc_imx.c | 2 ++ >> drivers/usb/chipidea/ci_hdrc_imx.h | 1 + >> drivers/usb/chipidea/usbmisc_imx.c | 13 +++++++++++++ >> 4 files changed, 17 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/usb/ci-hdrc-usb2.txt b/Documentation/devicetree/bindings/usb/ci-hdrc-usb2.txt >> index 0e03344..f83da66 100644 >> --- a/Documentation/devicetree/bindings/usb/ci-hdrc-usb2.txt >> +++ b/Documentation/devicetree/bindings/usb/ci-hdrc-usb2.txt >> @@ -84,6 +84,7 @@ i.mx specific properties >> - over-current-active-high: over current signal polarity is high active, >> typically over current signal polarity is low active. >> - external-vbus-divider: enables off-chip resistor divider for Vbus >> +- disable-int60ck: disable internal 60MHz clock for usb host2 or host3 on imx53 > > Doesn't this depend on something else like the type of phy connected? If > not, when can you do this or not? > We can disable it in OTG mode and with ULPI phy and Sascha Hauer think we can do it without dt binding for example based on PHY mode. So I will remove the binding and just disable clock if ULPI is selected. > Rob > Fabien