From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1753652AbbKQK0s (ORCPT <rfc822;w@1wt.eu>);
	Tue, 17 Nov 2015 05:26:48 -0500
Received: from mout.kundenserver.de ([212.227.126.135]:61679 "EHLO
	mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1752050AbbKQK0q (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Tue, 17 Nov 2015 05:26:46 -0500
From: Arnd Bergmann <arnd@arndb.de>
To: linux-arm-kernel@lists.infradead.org
Cc: Krzysztof Kozlowski <k.kozlowski@samsung.com>,
        Mark Brown <broonie@kernel.org>, alsa-devel@alsa-project.org,
        linux-samsung-soc@vger.kernel.org, Heiko Stuebner <heiko@sntech.de>,
        Sangbeom Kim <sbkim73@samsung.com>,
        Liam Girdwood <lgirdwood@gmail.com>, linux-kernel@vger.kernel.org,
        Vinod Koul <vinod.koul@intel.com>, Kukjin Kim <kgene@kernel.org>
Subject: Re: [PATCH 3/3] ASoC: samsung: pass filter function as pointer
Date: Tue, 17 Nov 2015 11:25:44 +0100
Message-ID: <22364793.tICMzOOh4L@wuerfel>
User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; )
In-Reply-To: <564A78A6.9010501@samsung.com>
References: <5466463.9HBcuLFGQf@wuerfel> <8896684.3di3I3vzeA@wuerfel> <564A78A6.9010501@samsung.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
X-Provags-ID: V03:K0:bw5FcLuxDHNPJyKIGYL10SrBe+KvvxfpR56w5pgaE8MM8IAY85M
 XrUd+k2fahxMwNcz+ngilQm5TdlRsxyk/w49bFpP4M8IIzEdAbb3VZjihx8O82+dfzsu33h
 60l6DT/p9M8ajaTTzyVn9Et3ipgx/pFMXrNC6f66oWri0XpTGRvhw2DLkBrUOU9zIGmhCTW
 gljrVDkizV0JOTvyad4HA==
X-UI-Out-Filterresults: notjunk:1;V01:K0:wqHX+EOIi4U=:PbeQE1tCAHeWwTVyrq49mD
 vUAuhFzeMiiFREiPCfES7EOrTKL3Ydl8cmqUSdP/GMykiZzUstxT/6WcDKJI1PGnY4MhiJfzQ
 JarJLo3eAK/a7wAgRHb2ww2BjbyPBvmcBoB8pcrJjEFzNyBnCwubmexNy2VODorkp3oeQMeQM
 i6ZLUa6LyddJkm67Z3ZsI4Dq6M/eEeKjyoDBgW/MdqkuuDCi6Dwirsc2KF+Y6LUJT7OhjJx+s
 fcmUDJKNwX85PIAbztLnk7EDQtPXW7hBuA2gXDegIDuhs/UEP86S0fSAUoDtTmMMw8QTzcRT4
 o94K+smoPziZBUn9CoDWMSJ1B+n4arZJR1lwVISc15mhyrke0QumBfQ4GS521M3KNTDKm/yIv
 AGsrj2z1Vy0eUoB6ZnFS53cDoxQxSuBA1nD5ijSS+KrqEkhIZaELagoP39YKDTqf9tBIGALVZ
 yoYz+MNKDFBDJwoLieOlpPE+0jG2qR81R1Cb+JB5JT32iiqM3A9UcVwTQYX1cgFAqs2ns2JEw
 hQlBaD5D3bfcZc9RFqKVIwtQitGYhDxiK/XMoXDHlmWuE708+lAk3ka5Rlx5sRFd7dGrS30Bj
 5dQFk12acEdbGWQ/93g4Nb4cYUT44sMWLzKY7kXQF2oGMrZJ/jYnWuOm5uANKRPE8QZfiu79L
 CeLu7HbN7tB75l3rCNmqgXAAqnIs6vpkIB+5GAbOyI2oNbuyUHmGx77a+jJuQLKnwMUfyZ/Me
 Ss0F93ZvhmvYkCmU
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tuesday 17 November 2015 09:45:26 Krzysztof Kozlowski wrote:
> On 14.11.2015 02:24, Arnd Bergmann wrote:
> > diff --git a/sound/soc/samsung/i2s.c b/sound/soc/samsung/i2s.c
> > index 0945b5de39e7..5a4133b6e6a6 100644
> > --- a/sound/soc/samsung/i2s.c
> > +++ b/sound/soc/samsung/i2s.c
> > @@ -1244,7 +1244,8 @@ static int samsung_i2s_probe(struct platform_device *pdev)
> >  		if (ret != 0)
> >  			return ret;
> >  
> > -		return samsung_asoc_dma_platform_register(&pdev->dev);
> > +		return samsung_asoc_dma_platform_register(&pdev->dev,
> > +						  i2s_pdata->dma_filter);
> >  	}
> 
> Here (and maybe in other places?) - NULL pointer exception. The pdata is
> NULL on all newer platforms (e.g. all Exynos).
> 
> BTW, later there is even check for NULL pdata which is pointed also by
> Smatch.

Thanks for spotting this! I'll fix it up.

	Arnd