From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A82C8ECE58C for ; Tue, 15 Oct 2019 20:10:55 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 8788B20854 for ; Tue, 15 Oct 2019 20:10:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732980AbfJOUKy (ORCPT ); Tue, 15 Oct 2019 16:10:54 -0400 Received: from gloria.sntech.de ([185.11.138.130]:39266 "EHLO gloria.sntech.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726717AbfJOUKy (ORCPT ); Tue, 15 Oct 2019 16:10:54 -0400 Received: from remote.shanghaihotelholland.com ([46.44.148.63] helo=phil.localnet) by gloria.sntech.de with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iKT9c-00080l-5K; Tue, 15 Oct 2019 22:10:48 +0200 From: Heiko Stuebner To: Johan Jonker Cc: robh+dt@kernel.org, mark.rutland@arm.com, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/2] include: dt-bindings: rockchip: remove RK_FUNC defines Date: Tue, 15 Oct 2019 22:10:42 +0200 Message-ID: <2236841.lnJlJmhppS@phil> In-Reply-To: <20191015191000.2890-2-jbx6244@gmail.com> References: <20191015191000.2890-1-jbx6244@gmail.com> <20191015191000.2890-2-jbx6244@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Johan, Am Dienstag, 15. Oktober 2019, 21:10:00 CEST schrieb Johan Jonker: > The defines RK_FUNC_1, RK_FUNC_2, RK_FUNC_3 and RK_FUNC_4 > are no longer used, so remove them to prevent > that someone start using them again. That won't work. Devicetree provides a slightly flexible promise of backwards compatibilty. So a new kernel should still work old devicetrees. (not exactly sure if this means dt-binaries and sources or only binaries) So while I think RK_FUNC_0-n should not be used anymore, we should probably just mark them as "deprecated" in a first step. Heiko > Signed-off-by: Johan Jonker > --- > include/dt-bindings/pinctrl/rockchip.h | 4 ---- > 1 file changed, 4 deletions(-) > > diff --git a/include/dt-bindings/pinctrl/rockchip.h b/include/dt-bindings/pinctrl/rockchip.h > index dc5c1c73d..2798b6c03 100644 > --- a/include/dt-bindings/pinctrl/rockchip.h > +++ b/include/dt-bindings/pinctrl/rockchip.h > @@ -50,9 +50,5 @@ > #define RK_PD7 31 > > #define RK_FUNC_GPIO 0 > -#define RK_FUNC_1 1 > -#define RK_FUNC_2 2 > -#define RK_FUNC_3 3 > -#define RK_FUNC_4 4 > > #endif >