public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Keith Owens <kaos@sgi.com>
To: Rusty Russell <rusty@rustcorp.com.au>
Cc: Andrew Morton <akpm@osdl.org>, Andi Kleen <ak@muc.de>,
	randy.dunlap@osdl.org, Sam Ravnborg <sam@ravnborg.org>,
	lkml - Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] Sort kallsyms in name order: kernel shrinks by 30k
Date: Tue, 11 May 2004 15:23:28 +1000	[thread overview]
Message-ID: <22374.1084253008@kao2.melbourne.sgi.com> (raw)
In-Reply-To: Your message of "Tue, 11 May 2004 15:08:55 +1000." <1084252135.31802.312.camel@bach>

On Tue, 11 May 2004 15:08:55 +1000, 
Rusty Russell <rusty@rustcorp.com.au> wrote:
>Admittedly, anyone who sets CONFIG_KALLSYMS doesn't care about space,
>it's a fairly trivial change.
>
>Name: Sort Kallsyms for Stem Compression
>Status: Booted on 2.6.6
>Depends: Misc/kallsyms-include-aliases.patch.gz
>
>Leaving the symbols sorted by name rather than address, so stem
>compression works more effectively.  Saves a little over 30k here.

Not sure this is a good idea.  proc_pid_wchan() calls kallsyms_lookup()
and has been identified as a bottleneck on systems with a large number
of processes.  top can consume a complete cpu out of 128 cpus, all
because of this bottleneck.  I was toying with the idea of doing a
binary chop on the address lookup, but this patch prevents that fix.


  reply	other threads:[~2004-05-11  5:24 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-05-11  5:08 [PATCH] Sort kallsyms in name order: kernel shrinks by 30k Rusty Russell
2004-05-11  5:23 ` Keith Owens [this message]
2004-05-11  8:08 ` Andi Kleen
2004-05-11 15:35   ` Randy.Dunlap
2004-05-11 23:16   ` Rusty Russell
2004-05-12  1:47     ` Matt Mackall
2004-05-12  6:00     ` Andi Kleen
  -- strict thread matches above, loose matches on Subject: below --
2004-05-13  0:05 Albert Cahalan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=22374.1084253008@kao2.melbourne.sgi.com \
    --to=kaos@sgi.com \
    --cc=ak@muc.de \
    --cc=akpm@osdl.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=randy.dunlap@osdl.org \
    --cc=rusty@rustcorp.com.au \
    --cc=sam@ravnborg.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox