From: Salih Erim <salih.erim@amd.com>
To: Jonathan Cameron <jic23@kernel.org>,
Guilherme Ivo Bozi <guilherme.bozi@usp.br>
Cc: "Conall O'Griofa" <conall.ogriofa@amd.com>,
"Michal Simek" <michal.simek@amd.com>,
"David Lechner" <dlechner@baylibre.com>,
"Nuno Sá" <nuno.sa@analog.com>,
"Andy Shevchenko" <andy@kernel.org>,
linux-iio@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 1/3] iio: adc: xilinx-ams: fix out-of-bounds channel lookup in event handling
Date: Tue, 12 May 2026 19:05:44 +0100 [thread overview]
Message-ID: <223817b7-8f6a-47d2-8362-19669815f48e@amd.com> (raw)
In-Reply-To: <20260512165444.4ae39d90@jic23-huawei>
Hi Jonathan,
>> I could not observe any indentation issues locally or from the raw mbox.
> FWIW they look good to me as well. Salih, I'd guess you have a local issue.
> b4 (on git.kernel.org) is really handy for ensuring none of those occur!
You are right, apologies for the noise. The tabs were converted to
spaces by my email client during export. I will use b4 for patch
retrieval going forward.
There is still the u32 dead code issue in patch 3/3
(event < 0 check on a u32 parameter in ams_event_to_channel()),
Guilherme has acknowledged.
I am currently testing the series on ZCU102 hardware. Will follow up
with my Reviewed-by and Tested-by tags on the v4.
Salih
>
> Jonathan
>
>>
>>>
>>> Salih
>>>
>>
>> --
>> Guilherme Ivo
>
next prev parent reply other threads:[~2026-05-12 18:05 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20260414224245.8493-1-guilherme.bozi@usp.br>
[not found] ` <20260425163449.547b7ed9@jic23-huawei>
2026-05-12 11:00 ` [PATCH v3 0/3] iio: adc: xilinx-ams: refactor alarm handling to table-driven design Guilherme Ivo Bozi
2026-05-12 11:02 ` Michal Simek
2026-05-12 11:26 ` Erim, Salih
2026-05-12 14:18 ` Salih Erim
[not found] ` <20260414224245.8493-2-guilherme.bozi@usp.br>
2026-05-12 14:22 ` [PATCH v3 1/3] iio: adc: xilinx-ams: fix out-of-bounds channel lookup in event handling Salih Erim
2026-05-12 15:40 ` Guilherme Ivo Bozi
2026-05-12 15:54 ` Jonathan Cameron
2026-05-12 18:05 ` Salih Erim [this message]
[not found] ` <20260414224245.8493-3-guilherme.bozi@usp.br>
2026-05-12 14:25 ` [PATCH v3 2/3] iio: adc: xilinx-ams: use guard(mutex) for automatic locking Salih Erim
[not found] ` <20260414224245.8493-4-guilherme.bozi@usp.br>
2026-05-12 14:34 ` [PATCH v3 3/3] iio: adc: xilinx-ams: refactor alarm mapping to table-driven approach Salih Erim
2026-05-12 15:46 ` Guilherme Ivo Bozi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=223817b7-8f6a-47d2-8362-19669815f48e@amd.com \
--to=salih.erim@amd.com \
--cc=andy@kernel.org \
--cc=conall.ogriofa@amd.com \
--cc=dlechner@baylibre.com \
--cc=guilherme.bozi@usp.br \
--cc=jic23@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michal.simek@amd.com \
--cc=nuno.sa@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox