From: Arnd Bergmann <arnd@arndb.de>
To: monstr@monstr.eu
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
David Miller <davem@davemloft.net>,
Michal Simek <michal.simek@xilinx.com>
Subject: Re: [PATCH] net: emaclite: include linux/of_irq.h
Date: Tue, 04 Jun 2013 10:44:36 +0200 [thread overview]
Message-ID: <2240834.ApHHSrFxQG@wuerfel> (raw)
In-Reply-To: <51ADA36D.7070607@monstr.eu>
On Tuesday 04 June 2013 10:21:01 Michal Simek wrote:
> On 06/03/2013 11:39 PM, Arnd Bergmann wrote:
> > The emaclite driver now calls of_irq_to_resource, which is
> > declared in linux/of_irq.h. Without this patch, I get a build
> > error on ARM.
>
> What about to just change it to use platform_get_resource()?
> I will test it.
Yes, that would work too. It seems the driver predates the automatic
generation of resources for IRQs and MMIO registers.
If you change the IRQ resource to platform_get_resource, you should
change the other one as well.
Arnd
next prev parent reply other threads:[~2013-06-04 8:44 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-03 21:39 [PATCH] net: emaclite: include linux/of_irq.h Arnd Bergmann
2013-06-04 8:21 ` Michal Simek
2013-06-04 8:44 ` Arnd Bergmann [this message]
2013-06-04 8:46 ` Michal Simek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2240834.ApHHSrFxQG@wuerfel \
--to=arnd@arndb.de \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=michal.simek@xilinx.com \
--cc=monstr@monstr.eu \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox