Re: [PATCH 08/25] serial: sh-sci: Make unsigned values in sci_baud_calc_hscif() unsigned

Geert Uytterhoeven
2015-11-19T20:49:11Z

On Thu, Nov 19, 2015 at 9:36 PM, Laurent Pinchart
<laurent.pinchart@ideasonboard.com> wrote:
>> --- a/drivers/tty/serial/sh-sci.c
>> +++ b/drivers/tty/serial/sh-sci.c

>> @@ -1880,9 +1881,9 @@ static void sci_baud_calc_hscif(unsigned int bps,
>> unsigned long freq, int *brr, for (c = 0; c <= 3; c++) {
>> /* integerized formulas from HSCIF documentation */
>> br = DIV_ROUND_CLOSEST(freq, (sr *
>> - (1 << (2 * c + 1)) * bps)) - 1;
>> - br = clamp(br, 0, 255);
>> - err = DIV_ROUND_CLOSEST(freq, ((br + 1) * bps * sr *
>> + (1 << (2 * c + 1)) * bps));
>> + br = clamp(br, 1U, 256U);
>> + err = DIV_ROUND_CLOSEST(freq, (br * bps * sr *
>> (1 << (2 * c + 1)) / 1000)) -
>> 1000;
>
> While you're at it you can remove the parentheses around the second argument
> to DIV_ROUND_CLOSEST, they're not needed.

The factor between parentheses is removed in the next patch.

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds