Re: [PATCH v4 2/3] i2c: iproc: Add Broadcom iProc I2C Driver

Russell King - ARM Linux
2015-01-17T22:40:46Z

On Sat, Jan 17, 2015 at 01:26:41PM -0800, Ray Jui wrote:
> time_left = wait_for_completion_timeout(&iproc_i2c->done, time_left);
>
> /* disable all interrupts */
> writel(0, iproc_i2c->base + IE_OFFSET);
>
> if (!time_left && !atomic_read(&iproc_i2c->transfer_is_successful)) {

Why are you using atomic_read() here?

--
FTTC broadband for 0.8mile line: currently at 10.5Mbps down 400kbps up
according to speedtest.net.