From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CC542C4338F for ; Sun, 22 Aug 2021 16:13:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A7E2760231 for ; Sun, 22 Aug 2021 16:13:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234156AbhHVQOc (ORCPT ); Sun, 22 Aug 2021 12:14:32 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41062 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231398AbhHVQOb (ORCPT ); Sun, 22 Aug 2021 12:14:31 -0400 Received: from mail-ej1-x631.google.com (mail-ej1-x631.google.com [IPv6:2a00:1450:4864:20::631]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4469AC061575 for ; Sun, 22 Aug 2021 09:13:50 -0700 (PDT) Received: by mail-ej1-x631.google.com with SMTP id e21so15592312ejz.12 for ; Sun, 22 Aug 2021 09:13:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=2SclzWe/a+WHkI1+v9aVDE2qt3aD/Uh5+eAnEPqlEbs=; b=Qow3Ok83b3Bry6lK3StPcchMLgt9renc1q+k7fPDsgvv4a2E/yskrCZkCwdn269C7N DUBh1N7mH7X4wfNBaUqV/Kaqb2kgDuu5Un1ODEuRgIpZrkGBSrZbdBZlg+vSnaqvN8dg ogNE5Hfi0UQ3krDC0xZyM7iR42orCWW4VryvI7x2+7IVG0oQMgxJ4a7wqQo5aEHVVe7J BEAZsl59fDluy71KTKVY8WLUkl5jW1RR1hyfuZEbp+m1uzu1wZODt9pjsQ0V9KRIBGbI f+TqP4yUi9NMYdB6lZDpWIFB67Q20diJ+DX+0dAG+N5smr0jT7Vm42DgzPDYSvnk2C9Q 0SPA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=2SclzWe/a+WHkI1+v9aVDE2qt3aD/Uh5+eAnEPqlEbs=; b=qILpoSLIMMCfGiwx3LHIIcEJuzZyqbQbK8NVBr24NYqApH5bbz4S+FeCit9wShtzL4 4ceoO9r4P0EyFs8gQaVRNsi+PJjbN2dZINJFbGrpkm9idULFljQELTVf1cEU+hnpio5H TI4bHp8m6ywxyN1zyQFQ+JKOz9YRF1VMr85nXeOHQ5+b1DS3Mo6CLZx5yyLNZQZhDvN0 RpLEt/01UnHmbp7gQX0CJI/hm7WNjRk04d0eP3I7ol99H8IAgULrN3EqjdczQHwZuQOS Ffcnj5PKZvF9G/MXtTiumK0o/Y4nr6/flZC73d1v9jsg/TT0SU2i5A6JYSQ/44UccaaR qNBQ== X-Gm-Message-State: AOAM532EhyslF3X/QcpQurvNU4jEWAff24E+qJ7GPm7zKN6+3oP3Cz9D nbMbMrchEsaXopc8quSqO7Q= X-Google-Smtp-Source: ABdhPJzoSyc7f19QewE/rEJBkxA/iBhxjuOrTs4J7MWU0qD+0RQaGG1zSqJcq/TSHIJ0SQItdqK/dg== X-Received: by 2002:a17:906:af4f:: with SMTP id ly15mr31842423ejb.175.1629648828905; Sun, 22 Aug 2021 09:13:48 -0700 (PDT) Received: from localhost.localdomain (host-79-22-100-164.retail.telecomitalia.it. [79.22.100.164]) by smtp.gmail.com with ESMTPSA id i6sm5925824ejd.57.2021.08.22.09.13.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 22 Aug 2021 09:13:48 -0700 (PDT) From: "Fabio M. De Francesco" To: Phillip Potter Cc: Greg Kroah-Hartman , Larry Finger , "open list:STAGING SUBSYSTEM" , open list , Michael Straube , Martin Kaiser Subject: Re: TODO list for staging/r8188eu Date: Sun, 22 Aug 2021 18:13:47 +0200 Message-ID: <2244233.5Ao9Nzikjg@localhost.localdomain> In-Reply-To: References: <1897566.d8lQ4HMSh1@localhost.localdomain> <2099975.VbY6Rib6K3@localhost.localdomain> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sunday, August 22, 2021 5:09:47 PM CEST Phillip Potter wrote: > On Sun, 22 Aug 2021 at 14:50, Fabio M. De Francesco > wrote: > > > > On Sunday, August 22, 2021 2:36:57 PM CEST Greg Kroah-Hartman wrote: > > > On Sun, Aug 22, 2021 at 09:41:20AM +0200, Fabio M. De Francesco wrote: > > > > Dear Larry, Philip, > > > > > > > > >From what I understand how the development process works, drivers in > > staging > > > > > > > > should have a to-do list in the TODO file. Please read https:// > > www.kernel.org/ > > > > doc/html/latest/process/2.Process.html?highlight=todo#staging-trees. > > > > > > > > Could you (as the maintainers of the r8188eu driver) please compile and > > > > provide the above mentioned list? > > > > > > Why don't you provide an initial list for people to work off of if you > > > feel it is needed here? > > > > > > thanks, > > > > > > greg k-h > > > > Unfortunately I'm not able to tell what is needed to do to have a driver > > improved so that it can be moved off staging. This work should be better > > addressed by someone who is much more experienced. > > > > For example, I read from other drivers TODO lists that cfg80211 and lib80211 > > are required but I don't know what they are. > > > > Regards, > > > > Fabio > > Dear Fabio, > > I believe Larry is working on hooking up CFG80211 again (he mentioned > going quite for a few days to work on it). As for other stuff that > needs doing, a few things come to mind: > > * Removal of dead code (whether or not this includes the > debugging/printing macros is a matter of opinion, I would say yes > personally) such as unused functions, struct fields, etc. > * Correction of code styling in the kernel (e.g. there is a lot of camel case). > * Use of in-kernel functionality and removal of unnecessary wrappers > where possible. > * Removal of the HAL layer and migration of its functionality into the > driver as a whole - this is an important one I would argue. > > There is likely to be lots of other items not on that list, but that > would seem to be the basis of a TODO list if we need one? > > Regards, > Phil Dear Philip, Thanks for this initial list. I suppose that every driver in staging should have it. If you like I could send a patch with the list you prepared, unless you prefer to make it yourself (since you wrote it). Please let me know what you prefer. We shouldn't forget that from time to time new people decide to enter kernel hacking through staging. I think that a list could help all future newcomers. Thanks, Fabio