From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751973AbdHGPVg (ORCPT ); Mon, 7 Aug 2017 11:21:36 -0400 Received: from mailout3.samsung.com ([203.254.224.33]:29717 "EHLO mailout3.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751927AbdHGPVc (ORCPT ); Mon, 7 Aug 2017 11:21:32 -0400 X-AuditID: b6c32a46-f790d6d000003bf5-69-59888579d63b From: Bartlomiej Zolnierkiewicz To: Julia Lawall , Zhang Rui , Eduardo Valentin Cc: bhumirks@gmail.com, kernel-janitors@vger.kernel.org, Kukjin Kim , Krzysztof Kozlowski , linux-pm@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 3/4] thermal: exynos: constify thermal_zone_of_device_ops structures Date: Mon, 07 Aug 2017 17:21:26 +0200 Message-id: <2246245.2R0fntX3Po@amdc3058> User-Agent: KMail/4.13.3 (Linux/3.13.0-96-generic; KDE/4.13.3; x86_64; ; ) In-reply-to: <1501965437-30730-4-git-send-email-Julia.Lawall@lip6.fr> MIME-version: 1.0 Content-transfer-encoding: 7Bit Content-type: text/plain; charset="us-ascii" X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrFKsWRmVeSWpSXmKPExsWy7bCmmW5la0ekwbwzphaf7vWzWcy/co3V YtmD04wWW29JW/Q/fs1scf78BnaLTY+B4pd3zWGz+Nx7hNFixvl9TBZPHvaxOXB77Jx1l91j 8Z6XTB6bVnWyeezdkuWxeUm9x+dNcgFsUVw2Kak5mWWpRfp2CVwZKx40sRb0clZcu3qDrYFx A3sXIyeHhICJxPFdu1ggbDGJC/fWs3UxcnEICexglDj0ZCULhPOZUeLYtNOMMB3zPixghKua 03QOquUro8TPuyuZQarYBKwkJravAusQESiSWNf8kx2kiFmghUli95cbrCAJYYEoieff/jGB 2CwCqhJN/e/AbF4BTYm1Ky6B2aICXhJb9rUD2RwcnAKuEnd/RECUCEr8mHwP7G5mAXmJffun skLYOhJnj60Du05C4Bi7xOInO8B6JQRkJTYdYIb4wEVi4d2ZUP8LS7w6vgXKlpLo7pgFZU9n lNj+WwJizmZGiVW7J0AlrCUOH78ItYxPouPwX3aI+bwSHW1CECUeEquubYMqd5R4tO0xNLQu A83ZtIdxAqP8LCQ/zELywywkPyxgZF7FKJZaUJybnlpsVGCkV5yYW1yal66XnJ+7iRGcgrTc djAuOedziFGAg1GJh3dFWkekEGtiWXFl7iFGCQ5mJRFe+WagEG9KYmVValF+fFFpTmrxIUZp DhYlcd66bdcihATSE0tSs1NTC1KLYLJMHJxSDYzF67tMA9Kywux2ymzOffjl8WpZs4n3ZD/F vzkz54pvc/WOI68SKmdUm32SsF9qGFt2+fhH2RdXzs7giY15nG8akX+vrKrjZrzUnV2bpSJu 8qXkneqe8dJsuvYxTUY7FqmV9yefSblhqKSmU1PlKW1l+vtOaXjDf+3A08Xbroaf3aW7Jr9D 2UOJpTgj0VCLuag4EQBl4fwXPQMAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrFIsWRmVeSWpSXmKPExsVy+t9jAd2K1o5Ig+5plhaf7vWzWcy/co3V YtmD04wWW29JW/Q/fs1scf78BnaLTY+B4pd3zWGz+Nx7hNFixvl9TBZPHvaxOXB77Jx1l91j 8Z6XTB6bVnWyeezdkuWxeUm9x+dNcgFsUW42GamJKalFCql5yfkpmXnptkqhIW66FkoKeYm5 qbZKEbq+IUFKCmWJOaVAnpEBGnBwDnAPVtK3S3DLWPGgibWgl7Pi2tUbbA2MG9i7GDk5JARM JOZ9WMAIYYtJXLi3nq2LkYtDSGAbo8TcJd0sEM5XRomdTZ3MIFVsAlYSE9tXgXWICBRJTFv0 DqyDWaCFSeLqnENsIAlhgSiJte9Xs4LYLAKqEk3975hAbF4BTYm1Ky6B2aICXhJb9rUD2Rwc nAKuEnd/REAsu8woMfv5E2aIekGJH5PvsYDYzALyEvv2T2WFsLUk1u88zjSBUWAWkrJZSMpm ISlbwMi8ilEstaA4Nz232KjASK84Mbe4NC9dLzk/dxMjMB63HdYK2MHYdC76EKMAB6MSDy9D ZkekEGtiWXFl7iFGCQ5mJRFe+WagEG9KYmVValF+fFFpTmrxIUZToPcmMkuJJucDU0VeSbyh iaWRiYGZmaGRgbGZkjjvhMAvEUIC6YklqdmpqQWpRTB9TBycUg2MXiWZVkY2W25clOr8fE/K eeXe4G+itmmze/+4cawolVR88fy3QZST6YxZv3reTHt8aDNXj/qfeUpbS/PObhaPmXgz/m7l eeYyFfevYuUzxN4Lh4mJTX5YyiFmWLb9y6/JFzZdc1glqaY35VHd+jUThV9wFV1/MGWr/9Kk dK3Ujq/sOpHbpzyQVWIpzkg01GIuKk4EAOACVe7dAgAA X-MTR: 20000000000000000@CPGS X-CMS-MailID: 20170807152128epcas2p4d4d1a4aab0e5f0c77ed84297f6b3228d X-Msg-Generator: CA X-Sender-IP: 182.195.42.80 X-Local-Sender: =?UTF-8?B?QmFydGxvbWllaiBab2xuaWVya2lld2ljehtTUlBPTC1LZXJu?= =?UTF-8?B?ZWwgKFRQKRvsgrzshLHsoITsnpAbU2VuaW9yIFNvZnR3YXJlIEVuZ2luZWVy?= X-Global-Sender: =?UTF-8?B?QmFydGxvbWllaiBab2xuaWVya2lld2ljehtTUlBPTC1LZXJu?= =?UTF-8?B?ZWwgKFRQKRtTYW1zdW5nIEVsZWN0cm9uaWNzG1NlbmlvciBTb2Z0d2FyZSBF?= =?UTF-8?B?bmdpbmVlcg==?= X-Sender-Code: =?UTF-8?B?QzEwG0VIURtDMTBDRDAyQ0QwMjczOTI=?= CMS-TYPE: 102P X-CMS-RootMailID: 20170805210250epcas2p2f6a808ee6e3e20cd1dc19457b96ddbf4 X-RootMTR: 20170805210250epcas2p2f6a808ee6e3e20cd1dc19457b96ddbf4 References: <1501965437-30730-1-git-send-email-Julia.Lawall@lip6.fr> <1501965437-30730-4-git-send-email-Julia.Lawall@lip6.fr> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Saturday, August 05, 2017 10:37:16 PM Julia Lawall wrote: > The thermal_zone_of_device_ops structure is only passed as the fourth > argument to thermal_zone_of_sensor_register, which is declared as const. > Thus the thermal_zone_of_device_ops structure itself can be const. > > Done with the help of Coccinelle. > > // > @r disable optional_qualifier@ > identifier i; > position p; > @@ > static struct thermal_zone_of_device_ops i@p = { ... }; > > @ok1@ > identifier r.i; > expression e1,e2,e3; > position p; > @@ > thermal_zone_of_sensor_register(e1,e2,e3,&i@p) > > @bad@ > position p != {r.p,ok1.p}; > identifier r.i; > struct thermal_zone_of_device_ops e; > @@ > e@i@p > > @depends on !bad disable optional_qualifier@ > identifier r.i; > @@ > static > +const > struct thermal_zone_of_device_ops i = { ... }; > // > > Signed-off-by: Julia Lawall Acked-by: Bartlomiej Zolnierkiewicz Eduardo/Zhang, Please queue this patch for upstream, thanks! Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics