public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: David Woodhouse <dwmw2@infradead.org>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: rmk@arm.linux.org.uk (Russell King), papadako@csd.uoc.gr (mythos),
	linux-kernel@vger.kernel.org,
	Ingo Oeser <ingo.oeser@informatik.tu-chemnitz.de>
Subject: Re: Can't compile 2.4.3 with agcc
Date: Mon, 23 Apr 2001 21:46:09 +0100	[thread overview]
Message-ID: <2250.988058769@redhat.com> (raw)
In-Reply-To: <E14rmF9-0000Ii-00@the-village.bc.nu>
In-Reply-To: <E14rmF9-0000Ii-00@the-village.bc.nu>



alan@lxorguk.ukuu.org.uk said:
> At least make the final printk a panic.. 

ingo.oeser@informatik.tu-chemnitz.de said:
> replace this with panic() please.

I considered this, but in the end decided to copy the method from a few 
lines above, which triggers in the case of no FPU and no FPE. I wasn't sure 
if there was a reason why we shouldn't panic() here.

RCS file: /inst/cvs/linux/include/asm-i386/bugs.h,v
retrieving revision 1.2.2.16
diff -u -r1.2.2.16 bugs.h
--- include/asm/bugs.h	2001/01/18 13:56:53	1.2.2.16
+++ include/asm/bugs.h	2001/04/23 20:40:57
@@ -80,8 +80,9 @@
 	 * Verify that the FXSAVE/FXRSTOR data will be 16-byte aligned.
 	 */
 	if (offsetof(struct task_struct, thread.i387.fxsave) & 15) {
-		extern void __buggy_fxsr_alignment(void);
-		__buggy_fxsr_alignment();
+		printk(KERN_EMERG "FXSAVE data are not 16-byte aligned in task_struct.\n");
+		printk(KERN_EMERG "This is usually caused by a buggy compiler (perhaps pgcc?)\n");
+		panic("Cannot continue.");
 	}
 	if (cpu_has_fxsr) {
 		printk(KERN_INFO "Enabling fast FPU save and restore... ");


--
dwmw2



  reply	other threads:[~2001-04-23 20:46 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2001-04-23 13:13 Can't compile 2.4.3 with agcc mythos
2001-04-23 14:48 ` Russell King
2001-04-23 15:27 ` Alan Cox
2001-04-23 15:52 ` David Woodhouse
2001-04-23 17:57   ` Ingo Oeser
2001-04-23 19:43   ` Alan Cox
2001-04-23 20:46     ` David Woodhouse [this message]
2001-04-23 21:03   ` Matan Ziv-Av
2001-04-23 21:16     ` David Woodhouse
2001-04-23 22:32       ` Andrzej Krzysztofowicz
2001-04-23 22:54         ` David Woodhouse
2001-04-24  8:53           ` Russell King
2001-04-24 12:37           ` David Woodhouse
2001-04-23 22:25   ` Horst von Brand
2001-04-23 22:35     ` David Woodhouse
2001-04-24 13:28       ` Horst von Brand
2001-04-24 13:30         ` David Woodhouse

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2250.988058769@redhat.com \
    --to=dwmw2@infradead.org \
    --cc=alan@lxorguk.ukuu.org.uk \
    --cc=ingo.oeser@informatik.tu-chemnitz.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=papadako@csd.uoc.gr \
    --cc=rmk@arm.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox