Re: [PATCH 5/6] arm64: dts: rockchip: Fix some dtb-check warnings

Krzysztof Kozlowski
2023-12-22T16:07:34Z

On 22/12/2023 12:05, Manuel Traut wrote:
> devicetree checks show some warnings:
>
> video-codec@fdea0400: 'interrupt-names' is a required property
> from schema $id: http://devicetree.org/schemas/media/rockchip-vpu.yaml#
>
> hdmi@fe0a0000: Unevaluated properties are not allowed ('power-domains' were unexpected)
> from schema $id: http://devicetree.org/schemas/display/rockchip/rockchip,dw-hdmi.yaml#
>

...

> @@ -819,7 +820,6 @@ hdmi: hdmi@fe0a0000 {
> clock-names = "iahb", "isfr", "cec", "ref";
> pinctrl-names = "default";
> pinctrl-0 = <&hdmitx_scl &hdmitx_sda &hdmitxm0_cec>;
> - power-domains = <&power RK3568_PD_VO>;
> reg-io-width = <4>;
> rockchip,grf = <&grf>;
> #sound-dai-cells = <0>;
> @@ -1123,7 +1123,7 @@ i2s2_2ch: i2s@fe420000 {
> dmas = <&dmac1 4>, <&dmac1 5>;
> dma-names = "tx", "rx";
> resets = <&cru SRST_M_I2S2_2CH>;
> - reset-names = "m";
> + reset-names = "tx-m", "rx-m";

That's not correct. Look at line above. How many entries it has?

Do not fix warnings just to make the warning disappear. Your change here
clearly suggests you did just that.

Best regards,
Krzysztof