Re: [PATCH 4/6] arm64: dts: rockchip: Add devicetree for Pine64 Pinetab2

Diederik de Haas
2023-12-23T14:18:11Z

[-- Attachment #1: Type: text/plain, Size: 1320 bytes --]

Hi Manuel,

On Saturday, 23 December 2023 14:59:34 CET Manuel Traut wrote:
> On Fri, Dec 22, 2023 at 06:01:54PM +0100, Diederik de Haas wrote:
> > On Friday, 22 December 2023 12:05:44 CET Manuel Traut wrote:
> > > +
> > > +&cru {
> > > + assigned-clocks = <&cru PLL_GPLL>, <&pmucru PLL_PPLL>, <&cru
> > > PLL_VPLL>; + assigned-clock-rates = <1200000000>, <200000000>,
> > > <500000000>; +};
> >
> > Attachment seem to work and for this I also have the attached patch in my
> > patch set.
> > IIRC without it you get an error in dmesg immediately at boot up which is
> > visible on the PT2 *if* you have immediate visual output (which is not
> > (yet?) the case in my image/kernel).
>
> you can see the message also by calling "dmesg --level err".
> I could verify that your patch removes the error message.

As I have been using that patch for a while, I couldn't verify it myself
anymore ;-)
If you use the (default) danctnix image, then you see it immediately at boot
up (at least the last time I tried it). With my (WIP) image, I only get visual
output after 5-7 seconds, so you'll likely miss that visual error if the image
you use also has a delay before outputting things on the screen.
But indeed, it would still show up in dmesg (without the patch).

> I will pick the change for v2.

Great :-)

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 228 bytes --]