From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.7 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A0F23C35673 for ; Sun, 23 Feb 2020 08:04:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 70C4A208C4 for ; Sun, 23 Feb 2020 08:04:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726678AbgBWIEu (ORCPT ); Sun, 23 Feb 2020 03:04:50 -0500 Received: from outbound.smtp.vt.edu ([198.82.183.121]:34480 "EHLO omr2.cc.vt.edu" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1725980AbgBWIEu (ORCPT ); Sun, 23 Feb 2020 03:04:50 -0500 Received: from mr4.cc.vt.edu (mr4.cc.ipv6.vt.edu [IPv6:2607:b400:92:8300:0:7b:e2b1:6a29]) by omr2.cc.vt.edu (8.14.4/8.14.4) with ESMTP id 01N84mRx021177 for ; Sun, 23 Feb 2020 03:04:48 -0500 Received: from mail-qk1-f200.google.com (mail-qk1-f200.google.com [209.85.222.200]) by mr4.cc.vt.edu (8.14.7/8.14.7) with ESMTP id 01N84h9g011917 for ; Sun, 23 Feb 2020 03:04:48 -0500 Received: by mail-qk1-f200.google.com with SMTP id q123so5953451qkb.1 for ; Sun, 23 Feb 2020 00:04:48 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:in-reply-to:references :mime-version:date:message-id; bh=1sDjklUSRS6YK2uiHcNctH5JVvBEzpdZpp/YBerFW8Q=; b=JYyQnU0potAIx2xfZz5rN25Um5Sl37nyef1I4vRFfT6AAt3Yzz5SaXsvfC67nBixH2 WW6pzdPXcgfvo/Zp0BhORznVqaL+leqa+RXrjcW9ocuBFdAkP3LCN+FI3x9nMqi2uPmZ 3wB5a4kqO6lyJ3ibXuHlbJvuwWge+faVDM/lN8xtxPAObsMk2DkH7Bc/dnWwGIth+YGL Zv6tdAWUL6njCGpjTld4G+pwWkvGV5Cwi0MH2fD1ListVujc3Ir33Ku9MG+ENY5YrefJ RlsWkKIi9Q3mb2ROJbd9mc02LTlKfil9Kw/7KNMuPAWCeA6sQuh9EXSWvYQXhkiwCmZ7 nJvw== X-Gm-Message-State: APjAAAV/E2CmvyfeDpNPP2YJwg1yTYMEoq/nrtoabdn8MhBe7snWSPAT 73UlKKPFynUaMmmaDOuTzDPNN+FbHIHJzG2zKH5ev+VUK6p6DIo6lznO2iudQDEvyFXSf1DIcyS MbZxTSFB/804oXJHNG0dKOoXlMV04ISgEQqk= X-Received: by 2002:ac8:4616:: with SMTP id p22mr42368499qtn.368.1582445083526; Sun, 23 Feb 2020 00:04:43 -0800 (PST) X-Google-Smtp-Source: APXvYqwLhVoWW2qQBKGujy+A80rCyV25rTP6B3Jur8sdum1qXflE5F1qwSnbKA4SgT1R0Q+CM8Rjsw== X-Received: by 2002:ac8:4616:: with SMTP id p22mr42368472qtn.368.1582445083208; Sun, 23 Feb 2020 00:04:43 -0800 (PST) Received: from turing-police ([2601:5c0:c001:c9e1::359]) by smtp.gmail.com with ESMTPSA id w2sm4302117qtd.97.2020.02.23.00.04.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 23 Feb 2020 00:04:41 -0800 (PST) From: "Valdis Kl=?utf-8?Q?=c4=93?=tnieks" X-Google-Original-From: "Valdis Kl=?utf-8?Q?=c4=93?=tnieks" X-Mailer: exmh version 2.9.0 11/07/2018 with nmh-1.7+dev To: Tetsuhiro Kohada cc: Mori.Takahiro@ab.MitsubishiElectric.co.jp, motai.hirotaka@aj.mitsubishielectric.co.jp, Greg Kroah-Hartman , linux-fsdevel@vger.kernel.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [RFC PATCH] staging: exfat: remove symlink feature. In-reply-to: <20200219055727.12867-1-Kohada.Tetsuhiro@dc.MitsubishiElectric.co.jp> References: <20200219055727.12867-1-Kohada.Tetsuhiro@dc.MitsubishiElectric.co.jp> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Date: Sun, 23 Feb 2020 03:04:40 -0500 Message-ID: <225183.1582445080@turing-police> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 19 Feb 2020 14:57:27 +0900, Tetsuhiro Kohada said: > Remove symlink feature completely. > > Becouse > -Uses reserved areas(defined in the Microsoft exfat specification), causing future incompatibilities. > -Not described in Microsoft exfat specifications or SD standards. > -For REMOVABLE media, causes incompatibility with other implementations. > -Not supported by other major exfat drivers. > -Not implemented symlink feature in linux FAT/VFAT. > > Remove this feature completely because of serious media compatibility issues. > (Can't enable even with CONFIG) > > If you have any questions about this patch, please let me know. > > Reviewed-by: Takahiro Mori > Signed-off-by: Tetsuhiro Kohada Symlink support would be nice, but Tetsuhiro is right - this driver's implementation isn't the way to do it. Heaving it over the side and getting a standard fat/vfat/exfat extension done is the right way. Acked-by: Valdis Kletnieks