From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1756715AbcKWVG1 (ORCPT <rfc822;w@1wt.eu>);
        Wed, 23 Nov 2016 16:06:27 -0500
Received: from mout.kundenserver.de ([212.227.126.131]:56314 "EHLO
        mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1756662AbcKWVG0 (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 23 Nov 2016 16:06:26 -0500
From: Arnd Bergmann <arnd@arndb.de>
To: Jaegeuk Kim <jaegeuk@kernel.org>
Cc: Chao Yu <yuchao0@huawei.com>, Yunlei He <heyunlei@huawei.com>,
        Damien Le Moal <damien.lemoal@wdc.com>,
        Fan Li <fanofcode.li@samsung.com>,
        linux-f2fs-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] f2fs: fix 32-bit build
Date: Wed, 23 Nov 2016 22:05:41 +0100
Message-ID: <2253375.qgaJy4NpnU@wuerfel>
User-Agent: KMail/5.1.3 (Linux/4.4.0-34-generic; KDE/5.18.0; x86_64; ; )
In-Reply-To: <20161123184226.GB24137@jaegeuk>
References: <20161122142033.1680054-1-arnd@arndb.de> <20161123184226.GB24137@jaegeuk>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
X-Provags-ID: V03:K0:f02dmICNBj3Bzaucgh74mMCoOyMAFWD4H94rndKBk5INEipCqGp
 h8/6sbeWq1QvT9SEPErDdwsdQRcrntQ43pP9PN/5yLVh9/gK5YmSEU5WVm64pr35Rvcd5yg
 Ts0ccvpr1g91PN1PjFwa1XKX8OwPIAvl38cDY8yq7UtFIfSxBj2xamUt7pzf4ZtN7SjQZjy
 e2+ObvThXrSTI7i50hPMw==
X-UI-Out-Filterresults: notjunk:1;V01:K0:FETBjPWQQyg=:Guf4gwWMiEEjRf1mhGFPAg
 OmfhSwzS14ItEBaniXe9APjljKC4zJ72cGlAnU3N5/UoVBMKABGcboqf6weLsFzgf2b6/GiHL
 ONRBUQWb0cLX4t02oppUrc8lNnesGBdwMYzGogjAFfQUc1ecuOr9H73l5YS8v9Q96qDn7RzPK
 p6Nj4c04ashGkwZ58IkDP+vpX39ojYSWr3w75xupT1J83wrOz29P+qtMYRvYRtYFIYQnXmjPM
 AU4Na6G/AcyQCHArG/lL/WfGOJZqpg51WLBWfJrrVKE9gi2WBYX//yCIAh7hEKGxtbitLzjtI
 4rnqI2QoINK35odtvXDPM9qmxZ96YKR0Jxsy8EoY5nfW92h0N2Zi6hbYuWt/p2+TXOoScT04K
 naCA1I5953tATAvLlaYFqUxaOWiCHcNBoWlXNhCUtxpAAsFGMkHcQP+A0kalyQyAqVY5QL4Es
 saBtCxrOcYmpDK7gXfz03PbfPlQ5810BWi6EJxwdFFOAvcR1vbzYU/mYDh14AwJy/bm/nE6PJ
 9UTo2uIRMX2pU8UZKxNJ01BlfhA8ZclBnn1h3lN5q6Y72zcAWQ5OmaSO8BaDcqJvwQn00RW8f
 oE7iZNCJxeNJvgGmmkGjph8vApxPTILx0KcCksGmEl7THTDl4nJlUw+u+autfS307c46Uyuik
 OsXpJiJEMA8eum+lbKFoOFK4RFNMiSp+L5r1RLkjdzY69Mv5aJaq3OSIRkIJjVbJ4y3OdzcGK
 +E2Ixlzr62/5PZ/N
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wednesday, November 23, 2016 10:42:26 AM CET Jaegeuk Kim wrote:
> 
> Unfortunately, the sector number is usually a 64-bit number, and
> we guarantee that bdev_zone_size() returns a power-of-two number.

The sentence no longer makes sense. Maybe

Fortunately, bdev_zone_size() is guaranteed to return a power-of-two
number, so we can replace the % operator with a cheaper bit mask.

> @@ -693,7 +693,8 @@ static int __f2fs_issue_discard_zone(struct f2fs_sb_info *sbi,
>         }
>         sector = SECTOR_FROM_BLOCK(blkstart);
>  
> -       if (sector % bdev_zone_size(bdev) || nr_sects != bdev_zone_size(bdev)) {
> +       if (sector & (bdev_zone_size(bdev) - 1) ||
> 

looks good, thanks for following up!

	Arnd