From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753628AbdIDN1D (ORCPT ); Mon, 4 Sep 2017 09:27:03 -0400 Received: from mailout1.samsung.com ([203.254.224.24]:35593 "EHLO mailout1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753588AbdIDN1B (ORCPT ); Mon, 4 Sep 2017 09:27:01 -0400 X-AuditID: b6c32a46-f790d6d000003bf5-49-59ad54a1b52a From: Bartlomiej Zolnierkiewicz To: Bhumika Goyal Cc: julia.lawall@lip6.fr, paulus@samba.org, linux@armlinux.org.uk, linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH] video: fbdev: make fb_videomode const Date: Mon, 04 Sep 2017 15:26:55 +0200 Message-id: <2256568.NTq7reR8tp@amdc3058> User-Agent: KMail/4.13.3 (Linux/3.13.0-96-generic; KDE/4.13.3; x86_64; ; ) In-reply-to: <1503761137-25263-1-git-send-email-bhumirks@gmail.com> MIME-version: 1.0 Content-transfer-encoding: 7Bit Content-type: text/plain; charset="us-ascii" X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFupgleLIzCtJLcpLzFFi42LZdljTQndhyNpIgyl/tSw+3etns1j24DSj xabH11gtTvR9YLW4vGsOm8WhqXsZLdYcWczuwO5x+dpFZo+ds+6ye+zdkuWxeUm9x9xdfYwe nzfJBbBFcdmkpOZklqUW6dslcGUsu7yBteAHW8WlT2oNjFtZuxg5OSQETCQWNq1lg7DFJC7c Ww9kc3EICexglJj6fBELhPOdUWLRsQVsMB33v3xiB7GFBHYzSrxrZYIo+soosWrbY7AEm4CV xMT2VYwgtoiAmsSNrpXMIEXMAssYJfZ++AQ2SRio6On3nWBFLAKqEm92TWQCsXkFNCUajh9g BrFFBbwktuxrB4tzCjhLrPnxnA2iRlDix+R7LCA2s4C8xL79U1khbB2Js8fWMUJceoRN4snB cAjbRWLj2k4mCFtY4tXxLewQtrTEs1UboeqnM0ps/y0BcqiEwGagb3ZPgCqyljh8/CLUAj6J jsN/geIcQHFeiY42IYgSD4l7sz+xQIQdJb4ejIcE0DRGicMLRCYwys1CcvUsJFfPQnL1Akbm VYxiqQXFuempxUYFRnrFibnFpXnpesn5uZsYwelDy20H45JzPocYBTgYlXh4C66siRRiTSwr rsw9xCjBwawkwnsieG2kEG9KYmVValF+fFFpTmrxIUZpDhYlcd66bdcihATSE0tSs1NTC1KL YLJMHJxSDYx2tuoaiade9anpnNtzRnehvtWmtM8CB2uXS/52dFg+o59z96sb3xhlGaZuCJ8c NTkhtuJnsdL/iSsX1Kqfbrjp7yutcu6avKr1YpGCZ8lMYgoyIdeTNqVNdTX59KD7lYCtx/uv y1678L67leqfabdI4YZ7udvX6nvcc/a9eD5B+FXLm21f/AyVWIozEg21mIuKEwFputZHGwMA AA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrBLMWRmVeSWpSXmKPExsVy+t9jAd2FIWsjDfpOSlt8utfPZrHswWlG i02Pr7FanOj7wGpxedccNotDU/cyWqw5spjdgd3j8rWLzB47Z91l99i7Jctj85J6j7m7+hg9 Pm+SC2CL4rJJSc3JLEst0rdL4MpYdnkDa8EPtopLn9QaGLeydjFyckgImEjc//KJvYuRi0NI YCejxNxZ7awQzldGiZsLJ4FVsQlYSUxsX8UIYosIqEnc6FrJDFLELLCMUeLji69MIAlhoKKn 33eCFbEIqEq82TURLM4roCnRcPwAM4gtKuAlsWVfO1icU8BZYs2P52wQ22YwSvw/+p0VokFQ 4sfkeywgNrOAvMS+/VNZIWwtifU7jzNNYOSfhaRsFpKyWUjKFjAyr2KUTC0ozk3PLTYqMMpL LdcrTswtLs1L10vOz93ECAzvbYe1+ncwPl4Sf4hRgINRiYdX4eaaSCHWxLLiytxDjBIczEoi vCeC10YK8aYkVlalFuXHF5XmpBYfYpTmYFES583smxEpJJCeWJKanZpakFoEk2Xi4JRqYFz1 +GWUpc6tJoNHZTW3L/tE/7s2oTfMOXbzrhOSLUfvXetv2HvhndqnIKmnDwPsQ3/JTq5UqNE3 KP8o/2YZi+wH+WbTezden32it6Jm+oJjf0918x+I2lcRHxqp8ISpX+p5RknAH0uOtQnH1z6N +jj3uYL0XemMoxWT87vYNgm/lei9tzX+0w4lluKMREMt5qLiRACvFB5YawIAAA== X-CMS-MailID: 20170904132657epcas2p23e35c3100e6e0d5bf7523e363cc6525f X-Msg-Generator: CA X-Sender-IP: 182.195.42.143 X-Local-Sender: =?UTF-8?B?QmFydGxvbWllaiBab2xuaWVya2lld2ljehtTUlBPTC1LZXJu?= =?UTF-8?B?ZWwgKFRQKRvsgrzshLHsoITsnpAbU2VuaW9yIFNvZnR3YXJlIEVuZ2luZWVy?= X-Global-Sender: =?UTF-8?B?QmFydGxvbWllaiBab2xuaWVya2lld2ljehtTUlBPTC1LZXJu?= =?UTF-8?B?ZWwgKFRQKRtTYW1zdW5nIEVsZWN0cm9uaWNzG1NlbmlvciBTb2Z0d2FyZSBF?= =?UTF-8?B?bmdpbmVlcg==?= X-Sender-Code: =?UTF-8?B?QzEwG0VIURtDMTBDRDAyQ0QwMjczOTI=?= CMS-TYPE: 102P X-CMS-RootMailID: 20170826152551epcas3p129fba70a978dca27cfe64d86ecefd404 X-RootMTR: 20170826152551epcas3p129fba70a978dca27cfe64d86ecefd404 References: <1503761137-25263-1-git-send-email-bhumirks@gmail.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Saturday, August 26, 2017 08:55:37 PM Bhumika Goyal wrote: > Make these const as they are only passed to a const argument of the > function fb_find_mode. > Done using Coccinelle. > > @match disable optional_qualifier@ > identifier s; > @@ > static struct fb_videomode s = {...}; > > @ref@ > position p; > identifier match.s; > @@ > s@p > > @good1@ > identifier match.s; > expression list[5] es; > position ref.p; > @@ > fb_find_mode(es,&s@p,...) > > @bad depends on !good1@ > position ref.p; > identifier match.s; > @@ > s@p > > @depends on forall !bad disable optional_qualifier@ > identifier match.s; > @@ > static > + const > struct fb_videomode s; > > Signed-off-by: Bhumika Goyal Patch queued for 4.14, thanks. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics