From: linmiaohe <linmiaohe@huawei.com>
To: Peter Xu <peterx@redhat.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"kvm@vger.kernel.org" <kvm@vger.kernel.org>
Subject: Re: [PATCH] KVM: Drop gfn_to_pfn_atomic()
Date: Thu, 5 Mar 2020 01:52:24 +0000 [thread overview]
Message-ID: <2256821e496c45f5baf97f3f8f884d59@huawei.com> (raw)
Peter Xu <peterx@redhat.com> writes:
>It's never used anywhere now.
>
>Signed-off-by: Peter Xu <peterx@redhat.com>
>---
> include/linux/kvm_host.h | 1 -
> virt/kvm/kvm_main.c | 6 ------
> 2 files changed, 7 deletions(-)
It seems we prefer to use kvm_vcpu_gfn_to_pfn_atomic instead now. :)
Patch looks good, but maybe we should update Documentation/virt/kvm/locking.rst too:
In locking.rst:
For direct sp, we can easily avoid it since the spte of direct sp is fixed
to gfn. For indirect sp, before we do cmpxchg, we call gfn_to_pfn_atomic()
to pin gfn to pfn, because after gfn_to_pfn_atomic()
Thanks.
Reviewed-by: Miaohe Lin <linmiaohe@huawei.com>
next reply other threads:[~2020-03-05 1:52 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-05 1:52 linmiaohe [this message]
2020-03-05 15:49 ` [PATCH] KVM: Drop gfn_to_pfn_atomic() Peter Xu
-- strict thread matches above, loose matches on Subject: below --
2020-03-04 17:51 Peter Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2256821e496c45f5baf97f3f8f884d59@huawei.com \
--to=linmiaohe@huawei.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=peterx@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox