public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: "Timur Kristóf" <timur.kristof@gmail.com>
To: Rosen Penev <rosenp@gmail.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: stable@vger.kernel.org,
	"Christian König" <christian.koenig@amd.com>,
	"Alex Deucher" <alexander.deucher@amd.com>,
	"Pan, Xinhui" <Xinhui.Pan@amd.com>,
	"David Airlie" <airlied@linux.ie>,
	"Daniel Vetter" <daniel@ffwll.ch>,
	"Harry Wentland" <harry.wentland@amd.com>,
	"Leo Li" <sunpeng.li@amd.com>,
	"Bin Lan" <bin.lan.cn@windriver.com>,
	"He Zhe" <zhe.he@windriver.com>,
	"Vitaly Prosyak" <vitaly.prosyak@amd.com>,
	"Alex Hung" <alex.hung@amd.com>,
	"Rodrigo Siqueira" <siqueira@igalia.com>,
	"Mario Limonciello" <Mario.Limonciello@amd.com>,
	"Ray Wu" <ray.wu@amd.com>, "Wayne Lin" <wayne.lin@amd.com>,
	"Roman Li" <Roman.Li@amd.com>, "Eric Yang" <Eric.Yang2@amd.com>,
	"Tony Cheng" <Tony.Cheng@amd.com>,
	"Mauro Rossi" <issor.oruam@gmail.com>,
	"open list:RADEON and AMDGPU DRM DRIVERS"
	<amd-gfx@lists.freedesktop.org>,
	"open list:DRM DRIVERS" <dri-devel@lists.freedesktop.org>,
	"open list" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH for 6.12 3/9] drm/amd/display: Disable fastboot on DCE 6 too
Date: Thu, 02 Apr 2026 13:56:35 +0200	[thread overview]
Message-ID: <2257770.9o76ZdvQCi@timur-hyperion> (raw)
In-Reply-To: <2026033157-trifocals-swerve-d18f@gregkh>

On Tuesday, March 31, 2026 1:03:34 PM Central European Summer Time Greg Kroah-
Hartman wrote:
> On Mon, Mar 30, 2026 at 02:38:35PM -0700, Rosen Penev wrote:
> > On Mon, Mar 30, 2026 at 7:21 AM Timur Kristóf <timur.kristof@gmail.com> 
wrote:
> > > On Monday, March 30, 2026 3:55:55 PM Central European Summer Time
> > > Christian
> > > 
> > > König wrote:
> > > > On 3/30/26 15:16, Timur Kristóf wrote:
> > > > > On Friday, March 27, 2026 12:47:10 AM Central European Summer Time
> > > > > Rosen
> > > > > Penev>
> > > > > 
> > > > > wrote:
> > > > >> From: Timur Kristóf <timur.kristof@gmail.com>
> > > > >> 
> > > > >> [ Upstream commit 7495962cbceb967e095233a5673ea71f3bcdee7e ]
> > > > >> 
> > > > >> It already didn't work on DCE 8,
> > > > >> so there is no reason to assume it would on DCE 6.
> > > > >> 
> > > > >> Signed-off-by: Timur Kristóf <timur.kristof@gmail.com>
> > > > >> Reviewed-by: Rodrigo Siqueira <siqueira@igalia.com>
> > > > >> Reviewed-by: Alex Deucher <alexander.deucher@amd.com>
> > > > >> Reviewed-by: Alex Hung <alex.hung@amd.com>
> > > > >> Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
> > > > >> Signed-off-by: Rosen Penev <rosenp@gmail.com>
> > > > > 
> > > > > This patch is incorrect and should not be backported.
> > > > > 
> > > > > (Note that the error is already fixed upstream. For stable kernels
> > > > > IMO
> > > > > it's
> > > > > best to drop this one.)
> > > > 
> > > > Is there some alternative which needs to be backported or should the
> > > > old
> > > > kernel just work out of the box because we never enabled some feature
> > > > there?
> > > > 
> > > > Apart from that the patch set looks good to me.
> > > 
> > > This patch had a typo and does the opposite of what it should, ie. it
> > > disables eDP fastboot on DCE10 and newer instead of disabling it on
> > > DCE8 and older.
> > > 
> > > The upstream fix is here:
> > > https://lists.freedesktop.org/archives/amd-gfx/2026-February/138577.html
> > > which disables eDP fastboot on DCE10 and older.
> > 
> > Not sure what the process is here. I make sure everything can be git
> > cherry-pick ed. In that case, both should be present.
> 
> I agree, I don't understand the problem here.  Just take the commits
> that are upstream including "fixes for the fixes".
> 
> Timur, what specifically do you want to see happen here?

Hi Greg,

It's up to you how you prefer to address this. I just wanted to call Rosen's 
attention to the above issue to avoid regressing the stable kernels.
I'm happy with either dropping the patch or backporting the patch together 
with its fix.

Thanks,
Timur



  reply	other threads:[~2026-04-02 11:56 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-26 23:47 [PATCH for 6.12 0/9] drm: amdgpu: backport suspend fixes for Rosen Penev
2026-03-26 23:47 ` [PATCH for 6.12 1/9] drm/amd/amdgpu: decouple ASPM with pcie dpm Rosen Penev
2026-03-26 23:47 ` [PATCH for 6.12 2/9] drm/amd/amdgpu: disable ASPM in some situations Rosen Penev
2026-03-26 23:47 ` [PATCH for 6.12 3/9] drm/amd/display: Disable fastboot on DCE 6 too Rosen Penev
2026-03-30 13:16   ` Timur Kristóf
2026-03-30 13:55     ` Christian König
2026-03-30 14:21       ` Timur Kristóf
2026-03-30 21:38         ` Rosen Penev
2026-03-31 11:03           ` Greg Kroah-Hartman
2026-04-02 11:56             ` Timur Kristóf [this message]
2026-03-31 10:55         ` Christian König
2026-03-26 23:47 ` [PATCH for 6.12 4/9] drm/amd/display: Reject modes with too high pixel clock on DCE6-10 Rosen Penev
2026-03-26 23:47 ` [PATCH for 6.12 5/9] drm/amd/display: Keep PLL0 running on DCE 6.0 and 6.4 Rosen Penev
2026-03-26 23:47 ` [PATCH for 6.12 6/9] drm/amd/display: Fix DCE 6.0 and 6.4 PLL programming Rosen Penev
2026-03-26 23:47 ` [PATCH for 6.12 7/9] drm/amd/display: Adjust DCE 8-10 clock, don't overclock by 15% Rosen Penev
2026-03-26 23:47 ` [PATCH for 6.12 8/9] drm/amd/display: Disable scaling on DCE6 for now Rosen Penev
2026-03-26 23:47 ` [PATCH for 6.12 9/9] drm/amd: Disable ASPM on SI Rosen Penev

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2257770.9o76ZdvQCi@timur-hyperion \
    --to=timur.kristof@gmail.com \
    --cc=Eric.Yang2@amd.com \
    --cc=Mario.Limonciello@amd.com \
    --cc=Roman.Li@amd.com \
    --cc=Tony.Cheng@amd.com \
    --cc=Xinhui.Pan@amd.com \
    --cc=airlied@linux.ie \
    --cc=alex.hung@amd.com \
    --cc=alexander.deucher@amd.com \
    --cc=amd-gfx@lists.freedesktop.org \
    --cc=bin.lan.cn@windriver.com \
    --cc=christian.koenig@amd.com \
    --cc=daniel@ffwll.ch \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=harry.wentland@amd.com \
    --cc=issor.oruam@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=ray.wu@amd.com \
    --cc=rosenp@gmail.com \
    --cc=siqueira@igalia.com \
    --cc=stable@vger.kernel.org \
    --cc=sunpeng.li@amd.com \
    --cc=vitaly.prosyak@amd.com \
    --cc=wayne.lin@amd.com \
    --cc=zhe.he@windriver.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox