From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760546AbcCDX0R (ORCPT ); Fri, 4 Mar 2016 18:26:17 -0500 Received: from mout.kundenserver.de ([212.227.126.131]:56753 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1760366AbcCDX0Q (ORCPT ); Fri, 4 Mar 2016 18:26:16 -0500 From: Arnd Bergmann To: Brian Norris Cc: David Woodhouse , linux-arm-kernel@lists.infradead.org, linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] mtd: avoid stack overflow in MTD CFI code Date: Sat, 05 Mar 2016 00:25:24 +0100 Message-ID: <2259988.Lj3BC6sPv6@wuerfel> User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; ) In-Reply-To: <20160304212159.GA55664@google.com> References: <1456748436-522413-1-git-send-email-arnd@arndb.de> <20160304212159.GA55664@google.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:JGUi+bGrcMdCBYd4zZx6QJo+gKidQlZkJrGK7kGiKgiZs+Ub+rn Ch4DZ9cb+fpXIM4/5iul3iG2wYSFY3HbIirc39dHLmU8OpAu95dPPYgZX9X4H3F6tItW38B WwHoyyXZl+tJsQle04MEjdtYKI++dE1dBe1fa+ZD2x+eA4M4d7ZDfsWOBO84G9AmLF/zaFS GJdiGYWVjWsNtZ1Xt9z2Q== X-UI-Out-Filterresults: notjunk:1;V01:K0:bw9lI8/N7Pw=:Jza1zjRMj0fBzf+Mullz3Z xS/UQWYRk/gtoKAdNFMmWJdCkVUHRUH22n02m/KKq8tJ6VBJkimTi0sFa3uP8chbMX3nL42ef uekgEwOQTh/yD3D2vruFkmVFCeN+leX2scrJsmhqFQ6W+WlcYsYEsNgE4WXW+NCoLXJW6jxjD fNyhKTqECIPVyzOSuLTmPJUdWH0itbrqzFgaXvqtUpt8wPsNtwZeBaGr9n08vs6aDvGEGQ2XK GHo2cUMtoJJicmckyEva3X00UD//u8dyQGTdulwveYKr+bKXy47nUiuW5fajs3kFNwWwQT0vN 8JrCtVvMUJ7f25fkWD+vZ/k98ZLlBrRWLEqQnVVG2AcARGnLbuSr84rdwRDqxgUTe074xlwxR QE7H//ZFBRSzFf8mFeLnujQmVqJvGpX4Q/0hwa55UlzpvU6LiOXBbFRh4h5TA8jf2ph/PwYkP cop3jGpiR4E4UqXE9Z7FodIMESt0bA0mzkZXv24IcLbEPdu2BVm+o+C1rUQPrCsblcLhGlWmz zoqF81BDoHLehiETsnG37bkv47aPMyacT+aHrnyup6IuQScu7A2d2XE1J+yrrZaK4hm8JdyOS QQ9Rj8vQWK2KxqZgQXyq7lJ1PYGJBQc7K26J5TDJlvpU+HU3IGzgFFLXC8C3C64AMs10obOpr AF/8eoNG4JnnhUmzJ33AO8Sx5nSLq0NSuCTprl6VaGFPL9F+f4CUl14JCMYDmi8yfL5eIG9+K o1BdOhqBFiaGFTPP Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Friday 04 March 2016 13:21:59 Brian Norris wrote: > > Looking a little closer at this... why do we need the changes to > include/linux/mtd/map.h again? It should be fine to leave these > definitions as-is, right? They don't contribute to the large stack > usage, do they? > > Maybe I'm just missing something obvious, so please do enlighten > It's been a while since I created the patch, and the originally failing configuration currently doesn't produce this (probably because something else changed). I remember that it was something rather subtle, but don't exactly remember what happened. I've reverted the patch now, trying to reproduce it on my randconfig setup, but I might not be able to get back to you in the next week while I'm traveling. Arnd