From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965814AbdKQQbB (ORCPT ); Fri, 17 Nov 2017 11:31:01 -0500 Received: from galahad.ideasonboard.com ([185.26.127.97]:57893 "EHLO galahad.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965652AbdKQQag (ORCPT ); Fri, 17 Nov 2017 11:30:36 -0500 From: Laurent Pinchart To: Philippe Ombredanne Cc: Mauro Carvalho Chehab , Linux Media Mailing List , Linux Kernel Mailing List , Mauro Carvalho Chehab , Sean Young , Hans Verkuil , Andi Shyti , David =?ISO-8859-1?Q?H=E4rdeman?= , Bhumika Goyal , Sakari Ailus , Arvind Yadav , Julia Lawall , Christophe JAILLET , Santosh Kumar Singh , Greg Kroah-Hartman , Thomas Gleixner , Evgeniy Polyakov Subject: Re: [PATCH 6/6] media: usb: add SPDX identifiers to some code I wrote Date: Fri, 17 Nov 2017 18:30:45 +0200 Message-ID: <2260317.oRs8TJsbN5@avalon> Organization: Ideas on Board Oy In-Reply-To: References: <20171117130104.1479fd43@vento.lan> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Philippe, On Friday, 17 November 2017 17:08:51 EET Philippe Ombredanne wrote: > On Fri, Nov 17, 2017 at 4:01 PM, Mauro Carvalho Chehab wrote: > > Em Fri, 17 Nov 2017 12:54:15 +0100 Philippe Ombredanne escreveu: > >> On Fri, Nov 17, 2017 at 11:21 AM, Mauro Carvalho Chehab wrote: > >> > As we're now using SPDX identifiers, on several > >> > media drivers I wrote, add the proper SPDX, identifying > >> > the license I meant. > >> > > >> > As we're now using the short license, it doesn't make sense to > >> > keep the original license text. > >> > > >> > Also, fix MODULE_LICENSE to properly identify GPL v2. > >> > > >> > Signed-off-by: Mauro Carvalho Chehab > >> > >> Mauro, > >> Thanks ++ .... I can now get rid of a special license detection rule I > >> had added for the specific language of your notices in the > >> scancode-toolkit! > >> > > :-) > > > > Yeah, I was too lazy to copy the usual GPL preamble on those > > drivers ;-) > > I guess I built a lazyness checker with scancode to keep you check then ;) > But FWIW you are not alone there and at least your notices are/were > consistent across files ... there are still several hundred variations > of GPL notices in the kernel each with subtle or byzantine changes. > > Some of them are rather funny like Evgeniy's thermal code being under > the "therms" of the GPL [1] Isn't that very appropriate for the thermal code ? https://en.wikipedia.org/wiki/Therm Sorry, couldn't resist :) > CC: Evgeniy Polyakov > > [1] > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/dri > vers/w1/slaves/w1_therm.c?h=v4.14-rc8#n8 -- Regards, Laurent Pinchart