public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Michael Neuling <mikey@neuling.org>
To: Russell King <rmk+lkml@arm.linux.org.uk>
Cc: "Robert P. J. Day" <rpjday@mindspring.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] ARM: Drop support for redundant "keepinitrd" boot-time param.
Date: Thu, 20 Sep 2007 18:15:48 +1000	[thread overview]
Message-ID: <2261.1190276148@neuling.org> (raw)
In-Reply-To: <20070920072233.GA10410@flint.arm.linux.org.uk>

> NAK.  "keepinitrd" is what people expect on ARM.
> 
> I'm frustrated that whoever invented "retain_initrd" didn't look
> around in the documentation to see if there was any existing
> implementation first.  The generic implementation should be fixed
> IMHO, or at least the option string moved into init/initramfs.c.

Sorry about that.  I'm happy to change retain_initrd to keep keepinitrd.
I don't think many people are using retain_initrd anyway (other than me
and some people I work with).

Otherwise we can support both for a while with something like (and
Robert's patch)....


From: Michael Neuling <mikey@neuling.org>

Make keepinitrd the same as retain_initrd for backwards compatibility
with ARM/AVR32 

Signed-off-by: Michael Neuling <mikey@neuling.org>
---
 init/initramfs.c |    7 +++++++
 1 file changed, 7 insertions(+)

Index: linux-2.6-ozlabs/init/initramfs.c
===================================================================
--- linux-2.6-ozlabs.orig/init/initramfs.c
+++ linux-2.6-ozlabs/init/initramfs.c
@@ -502,6 +502,13 @@ static int __init retain_initrd_param(ch
 }
 __setup("retain_initrd", retain_initrd_param);
 
+/* for backwards compatibility with ARM/AVR32 */
+static int __init keepinitrd_param(char *str)
+{
+	return retain_initrd_param(str);
+}
+__setup("keepinitrd", keepinitrd_param);
+
 extern char __initramfs_start[], __initramfs_end[];
 #ifdef CONFIG_BLK_DEV_INITRD
 #include <linux/initrd.h>


      reply	other threads:[~2007-09-20  8:18 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-09-19 16:06 [PATCH] ARM: Drop support for redundant "keepinitrd" boot-time param Robert P. J. Day
2007-09-20  7:22 ` Russell King
2007-09-20  8:15   ` Michael Neuling [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2261.1190276148@neuling.org \
    --to=mikey@neuling.org \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rmk+lkml@arm.linux.org.uk \
    --cc=rpjday@mindspring.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox