From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1761859AbcINMhZ (ORCPT ); Wed, 14 Sep 2016 08:37:25 -0400 Received: from mout.kundenserver.de ([212.227.126.187]:54724 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751168AbcINMhY (ORCPT ); Wed, 14 Sep 2016 08:37:24 -0400 From: Arnd Bergmann To: zhichang Cc: linux-arm-kernel@lists.infradead.org, Zhichang Yuan , linuxarm@huawei.com, linux-kernel@vger.kernel.org, lorenzo.pieralisi@arm.com, minyard@acm.org, benh@kernel.crashing.org, gabriele.paoloni@huawei.com, john.garry@huawei.com, liviu.dudau@arm.com, zourongrong@gmail.com Subject: Re: [PATCH V2 4/4] ARM64 LPC: support earlycon for UART connected to LPC Date: Wed, 14 Sep 2016 14:36:39 +0200 Message-ID: <2263975.sR08tijMiD@wuerfel> User-Agent: KMail/5.1.3 (Linux/4.4.0-34-generic; KDE/5.18.0; x86_64; ; ) In-Reply-To: <6e890161-0cd8-6027-f4e5-a222ceddd597@gmail.com> References: <1473255233-154297-1-git-send-email-yuanzhichang@hisilicon.com> <7585762.SZVHZyJdka@wuerfel> <6e890161-0cd8-6027-f4e5-a222ceddd597@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:h1xcWNkhi9Efc2535E8tDfdy9LyENnxRkA52nBEK4JmAJUCtVfb /gikYo/EVA4ue83jftLYBbzodJmL0mkVF4CmAY53SBr0EMNRb2m7FuR1oUBie3CO4HBTh9r 58mnzcgPu4ag9ASlRpHvnuiO4lPmE2WJerCXTYenQwHculH5PF9i46vNID2eolt0izytad9 6ZJ6qhiUSOXl1aFFsdfCw== X-UI-Out-Filterresults: notjunk:1;V01:K0:6Af7KfRcAaY=:s77TaK2a9yPfFdO4l+TN3T fOXa8FR4vWQVZIdRenNWHVVUd20M18HTCQ8q5mpYo9gk6hd8UOiuF/ijP3R5y7yi7471n0Qf3 HMLBjsmfoipG80ssQagP69AkK/ScjZm5oCFDZ0tD5zBUKQi9kR1WSPyaztQE24+D/uT8iME1d Xo7xxKbjavpVVt8xiH21uK/z/Rp+yMIUvyuFLlQQNagAsEOX1oyh29wlqmkyDZAgFiMeXfi7N GA+JAJJI4YJ1azDJ/rzaH5ToZDWPhyhw56BHCaFEnR4FS/W7YamQWF8WyROxOOsuMQLJkg662 BifSJSOizaHj72UueFF3QovmpNjuPNdzVmOBmC/Ry+ebmacjAHfkpZi71dYtyBm1EYjOHJ0he TyrMe3+lvMGP7LeUhq0cfEJZDubqtg37HFLNAtb5lA+an0ovbJVPxSCcts4MSJlyW0teZ47PR mYoSBY8BijSA9KPmP3TzjGWTm+iaF0+TXedBtM74AY5iaULySO0TLjbZX2KKDbgB4Hk6gvZFN hUqcyWY0YLxovK4O9sH/1pI2Oa26c5XIu3ZNVcZNgz0QJsjCtMg6kyDimvLIO/46MP4tmxzCH d22L4EywB0KXaLmgnjcE6XMgb8SLFHaP0dNdy9UF7kQckb2b92Pgs0d7s2F2NoLATWoycCnFW S7fVz3MpzF00psd01yvMQ71bMEyhTa3iGfb7ij2n5NCAsQpRZBBxazIBzB2Fj1jtp+w0dxZ1W molLMksG5ta8UNgO Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wednesday, September 14, 2016 7:26:22 PM CEST zhichang wrote: > > > > >> Hip06 LPC uart need two base addresses for earlycon. > >> 2. the IO type is mmio to introduce a memory base address to access LPC register file. But the real uart > >> IO type is UPIO_PORT. This is spcial... > > > > This sounds like a deficiency in the of_setup_earlycon() function, > > which can only handle MMIO addresses, and won't actually > > be able to understand nodes without a "ranges" property like > > you have here. > > > Yes. > The current of_setup_earlycon only support MMIO and the first reg property must be memory. > > We can not support our LPC uart without any new code. > But we can implement a private earlycon setup function and register > it to the __earlycon_table, things will be ok. I still think you should adapt of_setup_earlycon instead to handle IORESOURCE_IO registers. Arnd