Re: [PATCH 6/6] arm64: dts: qcom: add base QCS615 RIDE dts

Krzysztof Kozlowski
2024-08-28T09:11:44Z

On 28/08/2024 09:54, Lijuan Gao wrote:
>
>
> 在 8/28/2024 2:25 PM, Krzysztof Kozlowski 写道:
>> On Wed, Aug 28, 2024 at 10:02:16AM +0800, Lijuan Gao wrote:
>>> Add initial support for Qualcomm QCS615 RIDE board and enable
>>> the QCS615 RIDE board to shell with dcc console.
>>>
>>> Signed-off-by: Lijuan Gao <quic_lijuang@quicinc.com>
>>> ---
>>> arch/arm64/boot/dts/qcom/Makefile | 1 +
>>> arch/arm64/boot/dts/qcom/qcs615-ride.dts | 15 +++++++++++++++
>>> 2 files changed, 16 insertions(+)
>>>
>>> diff --git a/arch/arm64/boot/dts/qcom/Makefile b/arch/arm64/boot/dts/qcom/Makefile
>>> index 197ab325c0b9..c5503f189847 100644
>>> --- a/arch/arm64/boot/dts/qcom/Makefile
>>> +++ b/arch/arm64/boot/dts/qcom/Makefile
>>> @@ -110,6 +110,7 @@ dtb-$(CONFIG_ARCH_QCOM) += qcm6490-idp.dtb
>>> dtb-$(CONFIG_ARCH_QCOM) += qcm6490-shift-otter.dtb
>>> dtb-$(CONFIG_ARCH_QCOM) += qcs404-evb-1000.dtb
>>> dtb-$(CONFIG_ARCH_QCOM) += qcs404-evb-4000.dtb
>>> +dtb-$(CONFIG_ARCH_QCOM) += qcs615-ride.dtb
>>> dtb-$(CONFIG_ARCH_QCOM) += qcs6490-rb3gen2.dtb
>>> dtb-$(CONFIG_ARCH_QCOM) += qcs8550-aim300-aiot.dtb
>>> dtb-$(CONFIG_ARCH_QCOM) += qdu1000-idp.dtb
>>> diff --git a/arch/arm64/boot/dts/qcom/qcs615-ride.dts b/arch/arm64/boot/dts/qcom/qcs615-ride.dts
>>> new file mode 100644
>>> index 000000000000..31d32ad951b5
>>> --- /dev/null
>>> +++ b/arch/arm64/boot/dts/qcom/qcs615-ride.dts
>>> @@ -0,0 +1,15 @@
>>> +// SPDX-License-Identifier: BSD-3-Clause
>>> +/*
>>> + * Copyright (c) 2024, Qualcomm Innovation Center, Inc. All rights reserved.
>>> + */
>>> +/dts-v1/;
>>> +
>>> +#include "qcs615.dtsi"
>>> +/ {
>>> + model = "Qualcomm Technologies, Inc. QCS615 Ride";
>>> + compatible = "qcom,qcs615-ride", "qcom,qcs615";
>>> +
>>> + chosen {
>>> + bootargs = "console=hvc0";
>>
>> Noooo, last time I agreed on this, you told me later it is different.
>>
> In the early stages, enabling HVC is to more easily verify clock and
> PMIC related functions, as it’s difficult to debug without the console
> log. After the clock and PMIC are ready, we will enable the UART console.

Working serial is supposed to be part of the early submission.

Best regards,
Krzysztof