From: Mario Limonciello <superm1@kernel.org>
To: "Rafael J. Wysocki" <rafael@kernel.org>,
Linux ACPI <linux-acpi@vger.kernel.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
Linux PM <linux-pm@vger.kernel.org>,
Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
Subject: Re: [PATCH v1 0/3] ACPI: PM: s2idle: Tidy up the code and avoid invoking _DSM unnecessarily
Date: Thu, 9 Oct 2025 14:36:27 -0500 [thread overview]
Message-ID: <226584e9-7dca-49c8-a9a0-e7f8b6edd021@kernel.org> (raw)
In-Reply-To: <4699399.LvFx2qVVIh@rafael.j.wysocki>
On 10/9/25 2:25 PM, Rafael J. Wysocki wrote:
> Hi Everyone,
>
> There is an unused function related to s2idle on x86, so drop it (patch [1/3]).
>
> Also, some callback functions used in struct platform_s2idle_ops on x86 can
> be made static, so do that (patch [2/3]).
>
> Finally, the evaluation of LPS0 _DSM Function 1 is useless overhead unless
> printing PM debug messages has been enabled, so rearrange the code to only
> evaluate it when the data produced by it will be used (patch [3/3]).
>
> Please see changelogs of the individual patches for details.
>
> Thanks!
>
>
>
Reviewed-by: Mario Limonciello (AMD) <superm1@kernel.org>
prev parent reply other threads:[~2025-10-09 19:36 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-09 19:25 [PATCH v1 0/3] ACPI: PM: s2idle: Tidy up the code and avoid invoking _DSM unnecessarily Rafael J. Wysocki
2025-10-09 19:25 ` [PATCH v1 1/3] ACPI: PM: s2idle: Drop acpi_get_lps0_constraint() Rafael J. Wysocki
2025-10-09 19:26 ` [PATCH v1 2/3] ACPI: PM: s2idle: Staticise LPS0 callback functions Rafael J. Wysocki
2025-10-09 19:27 ` [PATCH v1 3/3] ACPI: PM: s2idle: Only retrieve constraints when needed Rafael J. Wysocki
2025-10-09 19:36 ` Mario Limonciello [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=226584e9-7dca-49c8-a9a0-e7f8b6edd021@kernel.org \
--to=superm1@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=srinivas.pandruvada@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox