From: "Rafael J. Wysocki" <rjw@rjwysocki.net>
To: Linux ACPI <linux-acpi@vger.kernel.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
Zhang Rui <rui.zhang@intel.com>,
Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>,
Michal Wilczynski <michal.wilczynski@intel.com>,
Hans de Goede <hdegoede@redhat.com>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Mika Westerberg <mika.westerberg@linux.intel.com>,
Heikki Krogerus <heikki.krogerus@linux.intel.com>,
Mario Limonciello <mario.limonciello@amd.com>
Subject: [PATCH v1 2/4] ACPI: OSL: Rearrange workqueue selection in acpi_os_execute()
Date: Wed, 29 Nov 2023 14:48:22 +0100 [thread overview]
Message-ID: <2267180.iZASKD2KPV@kreacher> (raw)
In-Reply-To: <3281896.aeNJFYEL58@kreacher>
From: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Replace the 3-branch if () statement used for selecting the target
workqueue in acpi_os_execute() with a switch () one that is more
suitable for this purpose and carry out the work item initialization
before it to avoid code duplication.
No intentional functional impact.
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
---
drivers/acpi/osl.c | 12 +++++++-----
1 file changed, 7 insertions(+), 5 deletions(-)
Index: linux-pm/drivers/acpi/osl.c
===================================================================
--- linux-pm.orig/drivers/acpi/osl.c
+++ linux-pm/drivers/acpi/osl.c
@@ -1092,19 +1092,21 @@ acpi_status acpi_os_execute(acpi_execute
dpc->function = function;
dpc->context = context;
+ INIT_WORK(&dpc->work, acpi_os_execute_deferred);
/*
* To prevent lockdep from complaining unnecessarily, make sure that
* there is a different static lockdep key for each workqueue by using
* INIT_WORK() for each of them separately.
*/
- if (type == OSL_NOTIFY_HANDLER) {
+ switch (type) {
+ case OSL_NOTIFY_HANDLER:
queue = kacpi_notify_wq;
- INIT_WORK(&dpc->work, acpi_os_execute_deferred);
- } else if (type == OSL_GPE_HANDLER) {
+ break;
+ case OSL_GPE_HANDLER:
queue = kacpid_wq;
- INIT_WORK(&dpc->work, acpi_os_execute_deferred);
- } else {
+ break;
+ default:
pr_err("Unsupported os_execute type %d.\n", type);
goto err;
}
next prev parent reply other threads:[~2023-11-29 13:52 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-29 13:45 [PATCH v1 0/4] ACPI: OSL: acpi_os_execute() improvements Rafael J. Wysocki
2023-11-29 13:46 ` [PATCH v1 1/4] ACPI: OSL: Rework error handling in acpi_os_execute() Rafael J. Wysocki
2023-11-29 14:10 ` Andy Shevchenko
2023-11-29 13:48 ` Rafael J. Wysocki [this message]
2023-11-29 14:48 ` [PATCH v1 2/4] ACPI: OSL: Rearrange workqueue selection " Andy Shevchenko
2023-11-29 13:50 ` [PATCH v1 3/4] ACPI: OSL: Allow Notify () handlers to run on all CPUs Rafael J. Wysocki
2023-11-29 14:09 ` Andy Shevchenko
2023-11-29 15:17 ` Rafael J. Wysocki
2023-11-29 13:52 ` [PATCH v1 4/4] ACPI: OSL: Use GFP_KERNEL for work item allocations Rafael J. Wysocki
2023-11-29 14:10 ` Andy Shevchenko
2023-12-04 15:26 ` Rafael J. Wysocki
2023-12-02 12:43 ` [PATCH v1 0/4] ACPI: OSL: acpi_os_execute() improvements Hans de Goede
2023-12-02 14:44 ` Rafael J. Wysocki
2023-12-04 16:32 ` Rafael J. Wysocki
2023-12-04 16:35 ` Hans de Goede
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2267180.iZASKD2KPV@kreacher \
--to=rjw@rjwysocki.net \
--cc=andriy.shevchenko@linux.intel.com \
--cc=hdegoede@redhat.com \
--cc=heikki.krogerus@linux.intel.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mario.limonciello@amd.com \
--cc=michal.wilczynski@intel.com \
--cc=mika.westerberg@linux.intel.com \
--cc=rui.zhang@intel.com \
--cc=srinivas.pandruvada@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox