From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D33C8C31E44 for ; Tue, 11 Jun 2019 21:53:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B1B7820896 for ; Tue, 11 Jun 2019 21:53:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2436632AbfFKVxY (ORCPT ); Tue, 11 Jun 2019 17:53:24 -0400 Received: from cloudserver094114.home.pl ([79.96.170.134]:53870 "EHLO cloudserver094114.home.pl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2407159AbfFKVxX (ORCPT ); Tue, 11 Jun 2019 17:53:23 -0400 Received: from 79.184.253.190.ipv4.supernova.orange.pl (79.184.253.190) (HELO kreacher.localnet) by serwer1319399.home.pl (79.96.170.134) with SMTP (IdeaSmtpServer 0.83.267) id 4ec8a4f90c997497; Tue, 11 Jun 2019 23:53:21 +0200 From: "Rafael J. Wysocki" To: Hans de Goede Cc: Linus Torvalds , Linux Kernel Mailing , Benjamin Tissoires , Jiri Kosina , linux-input@vger.kernel.org Subject: Strange regression in hid_llogitech_dj (was: Re: Linux 5.2-rc4) Date: Tue, 11 Jun 2019 23:53:20 +0200 Message-ID: <2268131.Lc39eCoc3j@kreacher> In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sunday, June 9, 2019 5:46:48 AM CEST Linus Torvalds wrote: > No, I'm not confused, and I haven't lost track of what day it is, I do > actually know that it's still Saturday here, not Sunday, and I'm just > doing rc4 a bit early because I'll be on an airplane during my normal > release time. And while I've done releases on airports and airplanes > before, I looked at my empty queue of pull requests and went "let's > just do it now". > > We've had a fairly calm release so far, and on the whole that seems to > hold. rc4 isn't smaller than rc3 was (it's a bit bigger), but rc3 was > fairly small, so the size increase isn't all that worrisome. I do hope > that we'll start actually shrinking now, though. I noticed that the cordless mouse used by me with one of the machines here stopped to work in 5.2-rc (up to and including the -rc4). Bisection turned up commit 74808f9115ce ("HID: logitech-dj: add support for non unifying receivers"). Of course, that commit does not revert cleanly from 5.2-rc4, but I have reverted the changes made by it in hid/hid-ids.h and I took the version of hid/hid-logitech-dj.c from commit b6aeeddef68d ("HID: logitech-dj: add logi_dj_recv_queue_unknown_work helper"), which is the parent of commit 74808f9115ce, and that made the mouse work again for me. Here's the output of "dmesg | grep -i logitech" from 5.2-rc4 with the above changes: [ 4.288905] usb 1-2: Manufacturer: Logitech [ 5.444621] input: Logitech USB Receiver as /devices/pci0000:00/0000:00:14.0/usb1/1-2/1-2:1.0/0003:046D:C52F.0002/input/input23 [ 5.446960] hid-generic 0003:046D:C52F.0002: input,hidraw1: USB HID v1.11 Mouse [Logitech USB Receiver] on usb-0000:00:14.0-2/input0 [ 5.451265] input: Logitech USB Receiver Consumer Control as /devices/pci0000:00/0000:00:14.0/usb1/1-2/1-2:1.1/0003:046D:C52F.0003/input/input24 [ 5.507545] hid-generic 0003:046D:C52F.0003: input,hiddev96,hidraw2: USB HID v1.11 Device [Logitech USB Receiver] on usb-0000:00:14.0-2/input1 Please let me know what you need to diagnose this. Thanks, Rafael